Support for targeting Android 13 (#22)

* Target update to API 33

* Added notifications permission handling (API 33)

* Updated libraries

* Removed Crashlytics

* Fixed camera access when targetting Android 13

* Fixed styling definitions when targetting Android 13

* Updated documentation reflecting these changes

Author: alexkok

CHANGELOG.md

@@ -1,11 +1,28 @@
 # Changelog
 
+## 3.7.0 - Released 19 Oct 2022
+
+**IMPORTANT**: Parley now targets Android 13 and requests notifications permission when needed.
+
+### Upgrading:
+
+- *DEPRECATION (styling)*: In the style `ParleyNotificationView`, the attribute `parley_icon` has been renamed to `parley_icon_connection`.
+
+### Changes:
+
+- Added requesting notifications permission when the `ParleyView` is visible to the user while the app doesn't this permissions yet.
+- Added message when the notifications permission is missing. The user will not receive chat notifications.
+- Updated source to target API 33.
+- Updated dependencies
+- *Addition (styling)*: Added attribute `parley_notification_icon_notifications` to styling `ParleyNotificationView` to configure the icon when user denied the notifications permission.
+
 ## 3.6.1 - Released 18 Oct 2022
 
-Parley now targets Android 12
+**IMPORTANT**: Parley now targets Android 12.
 
 - Added support for targeting Android 12 and higher.
 - Notification channels are now created when showing the `ParleyView`, causing Android 12 to request notifications permission if needed.
+- Updated source to target API 32.
 
 ## 3.6.0 - Released 29 Jul 2022
 

README.md

@@ -8,12 +8,14 @@ Easily setup a secure chat with the Parley Messaging Android library. The Parley
 
 ## Requirements
 
+- Java 11
 - Android 4.1+ (API 16+)
 - Android Studio 4.2+ (Android Gradle Plugin 4.2+)
 - Using AndroidX artifacts
 - Permissions (automatically added by the library)
   - android.permission.INTERNET - Required for chatting
   - android.permission.ACCESS_NETWORK_STATE - Required for detecting network changes
+  - android.permission.POST_NOTIFICATIONS - Required for showing notifications on API >= 33
   - android.permission.WRITE_EXTERNAL_STORAGE **(API < 19)** - Required for supporting images in the chat. *Only applied in API 18 and lower.*
 
 **Firebase**
@@ -44,7 +46,7 @@ allprojects {
 To integrate Parley, specify the following in your `app/build.gradle` file:
 
 ```groovy
-implementation 'com.github.parley-messaging:android-library:3.6.1'
+implementation 'com.github.parley-messaging:android-library:3.7.0'
 ```
 
 ### Upgrading

app/build.gradle

@@ -1,14 +1,13 @@
 apply plugin: 'com.android.application'
-apply plugin: 'io.fabric'
 
 android {
-    compileSdkVersion 32
+    compileSdkVersion 33
     defaultConfig {
         applicationId "nu.parley"
         minSdkVersion 16
-        targetSdkVersion 32
+        targetSdkVersion 33
         versionCode 1
-        versionName "1.0"
+        versionName "1.0.0"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     buildTypes {
@@ -18,35 +17,29 @@ android {
         }
     }
     compileOptions {
-        sourceCompatibility 1.8
-        targetCompatibility 1.8
+        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8
     }
 }
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
 
-    // Android X
-    implementation 'androidx.appcompat:appcompat:1.1.0'
-    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
-
-    implementation "com.android.support:design:28.0.0"
+    // AndroidX
+    implementation 'androidx.appcompat:appcompat:1.4.0'
 
     // Firebase
-    implementation 'com.google.firebase:firebase-core:17.5.1'
+    implementation 'com.google.firebase:firebase-core:19.0.0'
     implementation "com.google.firebase:firebase-messaging:22.0.0"
 
-    // Crashlytics
-    implementation 'com.crashlytics.sdk.android:crashlytics:2.10.1'
-
     // Library
-//    implementation 'com.github.parley-messaging:android-library:3.6.1' // Remote
+//    implementation 'com.github.parley-messaging:android-library:3.7.0' // Remote
     implementation project(':parley') // Local
 
     // Tests
-    testImplementation 'junit:junit:4.12'
-    androidTestImplementation 'androidx.test:runner:1.2.0'
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
+    testImplementation 'junit:junit:4.13.2'
+    androidTestImplementation 'androidx.test:runner:1.4.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
 }
 
 apply plugin: 'com.google.gms.google-services'

app/src/main/AndroidManifest.xml

@@ -4,7 +4,7 @@
     package="nu.parley">
 
     <application
-        android:allowBackup="true"
+        android:allowBackup="false"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:networkSecurityConfig="@xml/parley_network_security_config"
@@ -15,8 +15,8 @@
 
         <activity
             android:name=".ui.SplashActivity"
-            android:noHistory="true"
             android:exported="true"
+            android:noHistory="true"
             android:screenOrientation="portrait"
             android:theme="@style/AppTheme.FullScreen">
 

app/src/main/java/nu/parley/ui/BaseActivity.java

@@ -1,32 +1,18 @@
 package nu.parley.ui;
 
 import android.content.Context;
-import android.os.Bundle;
 import android.view.MenuItem;
 import android.view.View;
 import android.view.inputmethod.InputMethodManager;
-
-import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
 import androidx.appcompat.app.AlertDialog;
 import androidx.appcompat.app.AppCompatActivity;
 import androidx.appcompat.widget.Toolbar;
 
-import com.crashlytics.android.Crashlytics;
-
-import io.fabric.sdk.android.Fabric;
 import nu.parley.R;
-import nu.parley.repository.PreferenceRepository;
 
 public abstract class BaseActivity extends AppCompatActivity {
 
-    @Override
-    protected void onCreate(@Nullable Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-
-        Fabric.with(this, new Crashlytics());
-    }
-
     protected void setupToolbar() {
         Toolbar toolbar = findViewById(R.id.toolbar);
 

app/src/main/java/nu/parley/ui/IdentifierActivity.java

@@ -198,8 +198,9 @@ private void setOfflineMessagingEnabled() {
      * Registers a user for the chat with the provided customer id.
      * Here, the user authorization is generated by the device itself. However, generation of it
      * should be done elsewhere, as noted in {@link ParleyCustomerAuthorization}.
-     *
+     * <p>
      * Check out `setUserInformation()` for a simple example when the user authorization is known.
+     * </p>
      */
     private void registerUserWithCustomerId() {
         String customerId = new PreferenceRepository().getCustomerId(this);

build.gradle

@@ -2,12 +2,10 @@ buildscript {
     repositories {
         google()
         jcenter()
-        maven { url 'https://maven.fabric.io/public' }
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.5.1'
+        classpath 'com.android.tools.build:gradle:3.5.4'
         classpath 'com.google.gms:google-services:4.3.2'
-        classpath 'io.fabric.tools:gradle:1.31.1'
         classpath 'com.novoda:bintray-release:0.9.1'
     }
 }

parley/build.gradle

@@ -4,7 +4,7 @@ apply plugin: 'com.novoda.bintray-release'
 
 ext {
     libraryPackageIdentifier = 'nu.parley.android'
-    libraryVersion = '3.6.1'
+    libraryVersion = '3.7.0'
 }
 
 publish {
@@ -33,11 +33,11 @@ group = libraryPackageIdentifier
 version = libraryVersion
 
 android {
-    compileSdkVersion 32
+    compileSdkVersion 33
 
     defaultConfig {
         minSdkVersion 16
-        targetSdkVersion 32
+        targetSdkVersion 33
         versionCode 1
         versionName libraryVersion
 
@@ -47,19 +47,18 @@ android {
 }
 
 ext {
-    versionRetrofit = '2.6.0'
-    versionGlide = '4.10.0'
+    versionRetrofit = '2.9.0'
+    versionGlide = '4.14.1'
     versionMarkwon = '4.0.2'
 }
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
 
     // AndroidX artifacts
-    implementation 'androidx.annotation:annotation:1.2.0'
-    implementation 'androidx.appcompat:appcompat:1.1.0'
-    implementation 'androidx.recyclerview:recyclerview:1.1.0'
-    implementation 'androidx.cardview:cardview:1.0.0'
+    implementation 'androidx.appcompat:appcompat:1.4.0'
+    implementation 'androidx.recyclerview:recyclerview:1.2.1'
+    implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
 
     // Android Material
     implementation 'com.google.android.material:material:1.0.0'
@@ -77,18 +76,17 @@ dependencies {
 
     // Markdown support
     implementation "io.noties.markwon:core:${versionMarkwon}"
-    implementation  "io.noties.markwon:linkify:${versionMarkwon}"
+    implementation "io.noties.markwon:linkify:${versionMarkwon}"
 
     // Image Viewer
     implementation 'com.github.MikeOrtiz:TouchImageView:3.1.1'
-    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
 
-    testImplementation 'junit:junit:4.12'
-    androidTestImplementation 'junit:junit:4.12'
+    testImplementation 'junit:junit:4.13.2'
+    androidTestImplementation 'junit:junit:4.13.2'
 
-    androidTestImplementation 'androidx.test:runner:1.2.0'
-    androidTestImplementation 'androidx.test:rules:1.2.0'
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
+    androidTestImplementation 'androidx.test:runner:1.4.0'
+    androidTestImplementation 'androidx.test:rules:1.4.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
     androidTestImplementation 'com.novoda:espresso-support:1.0.0'
     androidTestImplementation('tools.fastlane:screengrab:2.1.0')
 }

parley/src/main/AndroidManifest.xml

@@ -3,6 +3,8 @@
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+
     <uses-permission
         android:name="android.permission.WRITE_EXTERNAL_STORAGE"
         android:maxSdkVersion="18" />
@@ -11,6 +13,12 @@
         android:name="android.hardware.camera"
         android:required="false" />
 
+    <queries>
+        <intent>
+            <action android:name="android.media.action.IMAGE_CAPTURE" />
+        </intent>
+    </queries>
+
     <application>
         <provider
             android:name=".util.TakePictureFileProvider"

parley/src/main/java/nu/parley/android/Parley.java

@@ -1,10 +1,13 @@
 package nu.parley.android;
 
+import static nu.parley.android.data.model.Message.SEND_STATUS_FAILED;
+import static nu.parley.android.notification.PushNotificationHandler.EVENT_START_TYPING;
+import static nu.parley.android.notification.PushNotificationHandler.EVENT_STOP_TYPING;
+
 import android.content.Context;
 import android.content.Intent;
 import android.os.Handler;
 import android.os.Looper;
-import android.provider.Settings;
 import android.util.Log;
 
 import androidx.annotation.NonNull;
@@ -34,10 +37,6 @@
 import nu.parley.android.view.ParleyView;
 import nu.parley.android.view.chat.MessageViewHolderFactory;
 
-import static nu.parley.android.data.model.Message.SEND_STATUS_FAILED;
-import static nu.parley.android.notification.PushNotificationHandler.EVENT_START_TYPING;
-import static nu.parley.android.notification.PushNotificationHandler.EVENT_STOP_TYPING;
-
 public final class Parley {
 
     public enum State {
@@ -150,8 +149,9 @@ public static void reset() {
 
     /**
      * Resets Parley back to its initial state (clearing the user information). Useful when logging out a user for example. Ensures that no user and chat data is left in memory.
-     *
+     * <p>
      * Leaves the network, offline messaging and referrer settings as is, these can be altered via the corresponding methods.
+     * </p>
      *
      * <b>Note</b>: Requires calling the `configure()` method again to use Parley.
      */
@@ -403,7 +403,7 @@ public void run() {
      * @return `true` if Parley handled this request, `false` otherwise
      */
     public static boolean onRequestPermissionsResult(final int requestCode, final @NonNull String[] permissions, @NonNull final int[] grantResults) {
-        if (requestCode == ParleyView.REQUEST_PERMISSION_ACCESS_CAMERA) {
+        if (requestCode == ParleyView.REQUEST_PERMISSION_ACCESS_CAMERA || requestCode == ParleyView.REQUEST_PERMISSION_NOTIFICATIONS) {
             if (getInstance().listener == null) {
                 // We will handle it when the listener is attached
                 new Handler().postDelayed(new Runnable() {