Skip to content

Commit 0d1081f

Browse files
committed
feat(CC-batch-8): review-athon round 1 followup
1 parent 59a441a commit 0d1081f

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

packages/code-connect/components/Slider/Slider.figma.tsx

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Button, Slider } from '@patternfly/react-core';
33
import MinusIcon from '@patternfly/react-icons/dist/esm/icons/minus-icon';
44
import PlusIcon from '@patternfly/react-icons/dist/esm/icons/plus-icon';
55

6-
// TODO: FIGMA: Define left/right actions
6+
// TODO: DESIGN: Define left/right actions
77
// Documentation for Slider can be found at https://www.patternfly.org/components/slider
88

99
figma.connect(
@@ -13,8 +13,7 @@ figma.connect(
1313
props: {
1414
// boolean
1515
isInputVisible: figma.boolean('Value input'),
16-
minmaxValues: figma.boolean('Min/max values'),
17-
isInputVisible: figma.boolean('Value input'),
16+
showBoundaries: figma.boolean('Min/max values'),
1817
startActions: figma.boolean('Left action', {
1918
true: <Button variant="plain" aria-label="Minus" onClick={() => {}} icon={<MinusIcon />} />,
2019
false: undefined
@@ -23,24 +22,24 @@ figma.connect(
2322
true: <Button variant="plain" aria-label="Plus" onClick={() => {}} icon={<PlusIcon />} />,
2423
false: undefined
2524
}),
25+
2626
// enum
27-
isContinuous: figma.enum('Type', { Continuous: true }),
27+
areCustomStepsContinuous: figma.enum('Type', { Continuous: true }),
2828
isDisabled: figma.enum('State', { Disabled: true }),
2929
showTicks: figma.enum('Type', { Discrete: true })
3030
},
3131
example: (props) => (
3232
<Slider
33-
areCustomStepsContinuous={props.isContinuous}
34-
isActive={props.isActive}
3533
isInputVisible={props.isInputVisible}
34+
showBoundaries={props.showBoundaries}
35+
startActions={props.startActions}
36+
endActions={props.endActions}
37+
areCustomStepsContinuous={props.areCustomStepsContinuous}
3638
isDisabled={props.isDisabled}
39+
showTicks={props.showTicks}
3740
max={200}
3841
step={50}
3942
value={100}
40-
showBoundaries={props.minmaxValues}
41-
showTicks={props.showTicks}
42-
startActions={props.startActions}
43-
endActions={props.endActions}
4443
/>
4544
)
4645
}

packages/code-connect/components/Tabs/HorizontalTab.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ figma.connect(
1313
props: {
1414
// string
1515
tabText: figma.string('Tab Text'),
16-
// eventKey: figma.string('Event key'), // TODO: FIGMA: Add event key
16+
// eventKey: figma.string('Event key'), // TODO: DESIGN: Add event key
1717

1818
// boolean
1919
actions: figma.boolean('Help button', {

packages/code-connect/components/Tabs/TabVertical.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ figma.connect(
4141

4242
// enum
4343
isDisabled: figma.enum('State', { Disabled: true })
44-
// eventKey: figma.string('Event key'), // TODO: FIGMA: Add event key
44+
// eventKey: figma.string('Event key'), // TODO: DESIGN: Add event key
4545
},
4646
example: (props) => (
4747
<Tab

packages/code-connect/components/TimeStamp/Timestamp.figma.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import figma from '@figma/code-connect';
22
import { Timestamp, TimestampTooltipVariant } from '@patternfly/react-core';
33

4-
// TODO: FIGMA: Refine intent, enum/dropdown options confuse date and time formats. They shoudd be separated
4+
// TODO: DESIGN: Refine intent, enum/dropdown options confuse date and time formats. They shoudd be separated
55
// Documentation for Timestamp can be found at https://www.patternfly.org/components/timestamp
66

77
figma.connect(

0 commit comments

Comments
 (0)