Skip to content
This repository was archived by the owner on Jun 26, 2022. It is now read-only.

Commit 60698c2

Browse files
committed
Remove Backbone.resolveDeferred. Closes gh-40.
1 parent 12b4a76 commit 60698c2

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

lib/dom-utils.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ utils.ajax = (function() {
4444
(xhr.status === 0 && window.location.protocol === 'file:')
4545
};
4646

47-
var end = function(xhr, options, promise) {
47+
var end = function(xhr, options, deferred) {
4848
return function() {
4949
if (xhr.readyState !== 4) return;
5050

@@ -54,12 +54,11 @@ utils.ajax = (function() {
5454
// Check for validity.
5555
if (isValid(xhr)) {
5656
if (options.success) options.success(data);
57-
if (promise) Backbone.resolveDeferred(promise, true, [data, xhr]);
57+
if (deferred) deferred.resolve(data);
5858
} else {
5959
var error = new Error('Server responded with a status of ' + status);
60-
error.code = status;
6160
if (options.error) options.error(xhr, status, error);
62-
if (promise) Backbone.resolveDeferred(promise, false, [xhr]);
61+
if (deferred) deferred.reject(xhr);
6362
}
6463
}
6564
};
@@ -69,14 +68,16 @@ utils.ajax = (function() {
6968
if (options.method == null) options.method = 'GET';
7069

7170
var xhr = new XMLHttpRequest();
72-
var promise = Backbone.Deferred && Backbone.Deferred();
71+
var deferred = Backbone.Deferred && Backbone.Deferred();
72+
7373
if (options.credentials) options.withCredentials = true;
74-
xhr.addEventListener('readystatechange', end(xhr, options, promise));
74+
xhr.addEventListener('readystatechange', end(xhr, options, deferred));
7575
xhr.open(options.method, options.url, true);
7676
if (options.headers) for (var key in options.headers) {
7777
xhr.setRequestHeader(key, options.headers[key]);
7878
}
7979
xhr.send(options.data);
80-
return promise;
80+
81+
return deferred ? deferred.promise : undefined;
8182
};
8283
})();

lib/sync.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,6 @@ Backbone.ajax = Backbone.$ ? function() {
8383
return Backbone.$.ajax.apply(Backbone.$, arguments);
8484
} : utils.ajax;
8585

86-
Backbone.Deferred = Backbone.$ ? function() {
86+
if (Backbone.$) Backbone.Deferred = function() {
8787
return new Backbone.$.Deferred();
88-
} : null;
89-
90-
Backbone.resolveDeferred = function(deferred, isResolved, args) {
91-
return null;
9288
};

0 commit comments

Comments
 (0)