PSMDB-810 explicitly close destination file to avoid error swallowing

igorsol · igorsol · commit 598a093f6927 · 2021-02-12T19:15:52.000+02:00
diff --git a/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp b/src/mongo/db/storage/wiredtiger/wiredtiger_kv_engine.cpp
@@ -1491,6 +1491,8 @@ static void copy_file_size(const boost::filesystem::path& srcFile, const boost::
         dst.write(bufptr, cnt);
         fsize -= cnt;
     }
+
+    dst.close();
 }
 
 Status WiredTigerKVEngine::_hotBackupPopulateLists(OperationContext* opCtx, const std::string& path, std::vector<DBTuple>& dbList, std::vector<FileTuple>& filesList) {

Original file line number	Diff line number	Diff line change
`@@ -1491,6 +1491,8 @@ static void copy_file_size(const boost::filesystem::path& srcFile, const boost::`
`1491`	`1491`	`dst.write(bufptr, cnt);`
`1492`	`1492`	`fsize -= cnt;`
`1493`	`1493`	`}`
	`1494`	`+`
	`1495`	`+ dst.close();`
`1494`	`1496`	`}`
`1495`	`1497`
`1496`	`1498`	`Status WiredTigerKVEngine::_hotBackupPopulateLists(OperationContext* opCtx, const std::string& path, std::vector<DBTuple>& dbList, std::vector<FileTuple>& filesList) {`