Fix ignore comments on protocol declarations. Closes #248

Author: ileitch

CHANGELOG.md

@@ -10,7 +10,7 @@
 
 ##### Bug Fixes
 
-- None.
+- Fix ignore comments on protocol declarations.
 
 ## 2.4.0 (2020-12-19)
 

Sources/PeripheryKit/Syntax/MetadataParser.swift

@@ -59,7 +59,7 @@ class MetadataParser: SyntaxVisitor {
             trivia: node.leadingTrivia,
             at: node.identifier.position
         )
-        return .skipChildren
+        return .visitChildren
     }
 
     override func visit(_ node: StructDeclSyntax) -> SyntaxVisitorContinueKind {

Tests/PeripheryTests/RetentionTest.swift

@@ -1085,6 +1085,17 @@ class RetentionTest: SourceGraphTestCase {
             XCTAssertReferenced((.varParameter, "param"), descendentOf: (.functionMethodInstance, "someFunc(param:)"))
             XCTAssertReferenced((.varParameter, "b"))
             XCTAssertReferenced((.varParameter, "c"))
+
+            XCTAssertReferenced(
+                (.varParameter, "param"),
+                descendentOf:
+                    (.functionMethodInstance, "protocolFunc(param:)"),
+                    (.protocol, "Fixture114Protocol"))
+            XCTAssertReferenced(
+                (.varParameter, "param"),
+                descendentOf:
+                    (.functionMethodInstance, "protocolFunc(param:)"),
+                    (.class, "Fixture114"))
         }
     }
 

Tests/RetentionFixtures/testIgnoreComments.swift

@@ -7,6 +7,11 @@ public class Fixture113 {
     }
 }
 
+public protocol Fixture114Protocol {
+    // periphery:ignore:parameters param
+    func protocolFunc(param: String)
+}
+
 public class Fixture114 {
     func referencedFunc() {}
 
@@ -15,3 +20,8 @@ public class Fixture114 {
         print(a)
     }
 }
+
+extension Fixture114: Fixture114Protocol {
+    // param is ignored becuse the protocol ignores it.
+    public func protocolFunc(param: String) {}
+}