Private methods attributed with @objc are also exposed to the Obj-C runtime. Closes #238

Author: ileitch

CHANGELOG.md

@@ -11,6 +11,7 @@
 ##### Bug Fixes
 
 - Fix indexing failure on unhandled declaration kinds, such as 'commentTag'.
+- `--retain-objc-accessible` also retains private declarations explicitly attributed with `@objc`.
 
 ## 2.3.1 (2020-12-06)
 

Sources/PeripheryKit/Analyzer/Analyzer.swift

@@ -43,6 +43,7 @@ public final class Analyzer {
         EntryPointAttributeRetainer.self,
         EntryPointFileRetainer.self,
         PubliclyAccessibleRetainer.self,
+        ObjCAccessibleRetainer.self,
         XCTestRetainer.self,
         SwiftUIRetainer.self,
         StructImplicitConstructorPropertyRetainer.self,

Sources/PeripheryKit/Analyzer/Visitors/ObjCAccessibleRetainer.swift

@@ -0,0 +1,34 @@
+import Foundation
+import Shared
+
+final class ObjCAccessibleRetainer: SourceGraphVisitor {
+    static func make(graph: SourceGraph) -> Self {
+        return self.init(graph: graph, configuration: inject())
+    }
+
+    private let graph: SourceGraph
+    private let configuration: Configuration
+
+    required init(graph: SourceGraph, configuration: Configuration) {
+        self.graph = graph
+        self.configuration = configuration
+    }
+
+    func visit() {
+        guard configuration.retainObjcAccessible else { return }
+
+        Declaration.Kind.accessibleKinds
+            .flatMap {
+                graph.declarations(ofKind: $0)
+            }
+            .filter {
+                $0.attributes.contains("objc") ||
+                    $0.attributes.contains("objc.name") ||
+                    $0.attributes.contains("objcMembers")
+            }
+            .forEach {
+                $0.isObjcAccessible = true
+                graph.markRetained($0)
+            }
+    }
+}

Tests/PeripheryTests/RetentionTest.swift

@@ -1159,6 +1159,7 @@ class RetentionTest: SourceGraphTestCase {
             XCTAssertReferenced((.class, "FixtureClass22"))
             XCTAssertReferenced((.varInstance, "someVar"))
             XCTAssertReferenced((.functionMethodInstance, "someMethod()"))
+            XCTAssertReferenced((.functionMethodInstance, "somePrivateMethod()"))
         }
     }
 
@@ -1181,6 +1182,7 @@ class RetentionTest: SourceGraphTestCase {
             XCTAssertReferenced((.class, "FixtureClass25"))
             XCTAssertReferenced((.varInstance, "someVar"))
             XCTAssertReferenced((.functionMethodInstance, "someMethod()"))
+            XCTAssertNotReferenced((.functionMethodInstance, "somePrivateMethod()"))
         }
     }
     #endif

Tests/RetentionFixtures/testObjcMembersAnnotationRetainsMembers.swift

@@ -3,4 +3,5 @@ import Foundation
 @objcMembers class FixtureClass25: NSObject {
     var someVar: String?
     func someMethod() {}
+    private func somePrivateMethod() {} // @objcMembers doesn't apply to private methods.
 }

Tests/RetentionFixtures/testRetainsObjcAnnotatedMembers.swift

@@ -3,4 +3,5 @@ import Foundation
 @objc class FixtureClass22: NSObject {
     @objc var someVar: String?
     @objc func someMethod() {}
+    @objc private func somePrivateMethod() {}
 }