Stabilize output by sorting modules (#621)

Lutzifer · web-flow · commit 55f114a84ee2 · 2023-06-21T05:08:23.000-04:00
Otherwise, the output changes randomly. As we commit the results to git to show changes in PRs, sorting the modules avoids unnecessary changes.
diff --git a/Sources/Frontend/Formatters/OutputFormatter.swift b/Sources/Frontend/Formatters/OutputFormatter.swift
@@ -47,7 +47,7 @@ extension OutputFormatter {
                     ($0.location, "Protocol '\(name)' conformance is redundant")
                 }
             case let .redundantPublicAccessibility(modules):
-                let modulesJoined = modules.joined(separator: ", ")
+                let modulesJoined = modules.sorted().joined(separator: ", ")
                 description += " is declared public, but not used outside of \(modulesJoined)"
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ extension OutputFormatter {`
`47`	`47`	`($0.location, "Protocol '\(name)' conformance is redundant")`
`48`	`48`	`}`
`49`	`49`	`case let .redundantPublicAccessibility(modules):`
`50`		`- let modulesJoined = modules.joined(separator: ", ")`
	`50`	`+ let modulesJoined = modules.sorted().joined(separator: ", ")`
`51`	`51`	`description += " is declared public, but not used outside of \(modulesJoined)"`
`52`	`52`	`}`
`53`	`53`	`} else {`