Merge pull request #143 from php-school/scrutinizer-patch-1

AydinHassan · web-flow · commit 312b7a61829f · 2016-12-08T22:40:25.000+01:00
Scrutinizer Auto-Fixes
diff --git a/app/config.php b/app/config.php
@@ -45,7 +45,6 @@
 use PhpSchool\PhpWorkshop\Result\Cli\RequestFailure as CliRequestFailure;
 use PhpSchool\PhpWorkshop\Result\Failure;
 use PhpSchool\PhpWorkshop\Result\FunctionRequirementsFailure;
-use PhpSchool\PhpWorkshop\Result\StdOutFailure;
 use PhpSchool\PhpWorkshop\ResultAggregator;
 use PhpSchool\PhpWorkshop\ResultRenderer\CgiResultRenderer;
 use PhpSchool\PhpWorkshop\ResultRenderer\CliResultRenderer;
diff --git a/src/ExerciseRunner/CliRunner.php b/src/ExerciseRunner/CliRunner.php
@@ -19,7 +19,6 @@
 use PhpSchool\PhpWorkshop\Result\Cli\GenericFailure;
 use PhpSchool\PhpWorkshop\Result\Cli\Success;
 use PhpSchool\PhpWorkshop\Result\ResultInterface;
-use PhpSchool\PhpWorkshop\Result\StdOutFailure;
 use PhpSchool\PhpWorkshop\Utils\ArrayObject;
 use Symfony\Component\Process\Process;
 
diff --git a/src/Output/StdOutput.php b/src/Output/StdOutput.php
@@ -4,7 +4,6 @@
 
 use Colors\Color;
 use PhpSchool\CliMenu\Terminal\TerminalInterface;
-use Psr\Http\Message\RequestInterface;
 
 /**
  * Class StdOutput
diff --git a/src/Result/Cgi/GenericFailure.php b/src/Result/Cgi/GenericFailure.php
@@ -24,7 +24,7 @@ class GenericFailure extends Failure implements FailureInterface
 
     /**
      * @param RequestInterface $request The request that caused the failure.
-     * @param null $reason
+     * @param string|null $reason
      */
     public function __construct(RequestInterface $request, $reason = null)
     {
diff --git a/src/Result/Cli/GenericFailure.php b/src/Result/Cli/GenericFailure.php
@@ -24,7 +24,7 @@ class GenericFailure extends Failure implements FailureInterface
 
     /**
      * @param ArrayObject $args The arguments that caused the failure.
-     * @param null $reason The reason (if any) of the failure.
+     * @param string|null $reason The reason (if any) of the failure.
      */
     public function __construct(ArrayObject $args, $reason = null)
     {
diff --git a/src/ResultRenderer/CgiResultRenderer.php b/src/ResultRenderer/CgiResultRenderer.php
@@ -2,7 +2,6 @@
 
 namespace PhpSchool\PhpWorkshop\ResultRenderer;
 
-use PhpSchool\PhpWorkshop\Result\CgiOutRequestFailure;
 use PhpSchool\PhpWorkshop\Result\Cgi\CgiResult;
 use PhpSchool\PhpWorkshop\Result\Cgi\FailureInterface;
 use PhpSchool\PhpWorkshop\Result\Cgi\ResultInterface;
diff --git a/test/Asset/CgiExerciseImpl.php b/test/Asset/CgiExerciseImpl.php
@@ -2,12 +2,9 @@
 
 namespace PhpSchool\PhpWorkshopTest\Asset;
 
-use PhpSchool\PhpWorkshop\Check\ComposerCheck;
 use PhpSchool\PhpWorkshop\Exercise\CgiExercise;
-use PhpSchool\PhpWorkshop\Exercise\CliExercise;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
-use PhpSchool\PhpWorkshop\ExerciseCheck\ComposerExerciseCheck;
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
 use Psr\Http\Message\RequestInterface;
 
diff --git a/test/Asset/CliExerciseImpl.php b/test/Asset/CliExerciseImpl.php
@@ -2,11 +2,9 @@
 
 namespace PhpSchool\PhpWorkshopTest\Asset;
 
-use PhpSchool\PhpWorkshop\Check\ComposerCheck;
 use PhpSchool\PhpWorkshop\Exercise\CliExercise;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
-use PhpSchool\PhpWorkshop\ExerciseCheck\ComposerExerciseCheck;
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
 
 /**
diff --git a/test/Command/PrintCommandTest.php b/test/Command/PrintCommandTest.php
@@ -2,12 +2,9 @@
 
 namespace PhpSchool\PhpWorkshop\Command;
 
-use Colors\Color;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
 use PhpSchool\PhpWorkshopTest\Asset\CliExerciseInterface;
-use PhpSchool\PhpWorkshopTest\Asset\ComposerExercise;
 use PHPUnit_Framework_TestCase;
-use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\ExerciseRepository;
 use PhpSchool\PhpWorkshop\MarkdownRenderer;
 use PhpSchool\PhpWorkshop\Output\OutputInterface;
diff --git a/test/ExerciseRunner/CgiRunnerTest.php b/test/ExerciseRunner/CgiRunnerTest.php
@@ -14,7 +14,6 @@
 use PhpSchool\PhpWorkshop\Input\Input;
 use PhpSchool\PhpWorkshop\Output\StdOutput;
 use PhpSchool\PhpWorkshop\Result\Cgi\RequestFailure;
-use PhpSchool\PhpWorkshop\Result\CgiOutRequestFailure;
 use PhpSchool\PhpWorkshop\Result\Cgi\CgiResult;
 use PhpSchool\PhpWorkshop\Result\Failure;
 use PhpSchool\PhpWorkshop\ResultAggregator;
diff --git a/test/ExerciseRunner/CliRunnerTest.php b/test/ExerciseRunner/CliRunnerTest.php
@@ -16,8 +16,6 @@
 use PhpSchool\PhpWorkshop\Result\Cli\CliResult;
 use PhpSchool\PhpWorkshop\Result\Cli\GenericFailure;
 use PhpSchool\PhpWorkshop\Result\Cli\RequestFailure;
-use PhpSchool\PhpWorkshop\Result\StdOutFailure;
-use PhpSchool\PhpWorkshop\Result\Success;
 use PhpSchool\PhpWorkshop\ResultAggregator;
 use PhpSchool\PhpWorkshop\Solution\SingleFileSolution;
 use PhpSchool\PhpWorkshopTest\Asset\CliExerciseInterface;
diff --git a/test/ExerciseRunner/Factory/CustomVerifyingRunnerFactoryTest.php b/test/ExerciseRunner/Factory/CustomVerifyingRunnerFactoryTest.php
@@ -3,7 +3,6 @@
 namespace PhpSchool\PhpWorkshopTest\ExerciseRunner\Factory;
 
 use PhpSchool\PhpWorkshop\CommandDefinition;
-use PhpSchool\PhpWorkshop\Exercise\CustomVerifyingExercise;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
 use PhpSchool\PhpWorkshop\ExerciseRunner\CustomVerifyingRunner;
diff --git a/test/Listener/CodePatchListenerTest.php b/test/Listener/CodePatchListenerTest.php
@@ -3,7 +3,6 @@
 namespace PhpSchool\PhpWorkshopTest\Listener;
 
 use PhpSchool\PhpWorkshop\CodePatcher;
-use PhpSchool\PhpWorkshop\Event\Event;
 use PhpSchool\PhpWorkshop\Event\ExerciseRunnerEvent;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Input\Input;
diff --git a/test/Listener/PrepareSolutionListenerTest.php b/test/Listener/PrepareSolutionListenerTest.php
@@ -2,7 +2,6 @@
 
 namespace PhpSchool\PhpWorkshopTest\Listener;
 
-use PhpSchool\PhpWorkshop\Event\Event;
 use PhpSchool\PhpWorkshop\Event\ExerciseRunnerEvent;
 use PhpSchool\PhpWorkshop\Exercise\CliExercise;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
diff --git a/test/Result/Cli/GenericFailureTest.php b/test/Result/Cli/GenericFailureTest.php
@@ -6,7 +6,6 @@
 use PhpSchool\PhpWorkshop\Result\CLi\GenericFailure;
 use PhpSchool\PhpWorkshop\Utils\ArrayObject;
 use PHPUnit_Framework_TestCase;
-use Psr\Http\Message\RequestInterface;
 
 /**
  * @author Aydin Hassan <aydin@hotmail.co.uk>
diff --git a/test/ResultAggregatorTest.php b/test/ResultAggregatorTest.php
@@ -6,7 +6,6 @@
 use PhpSchool\PhpWorkshop\Check\CheckInterface;
 use PhpSchool\PhpWorkshop\Result\Cli\CliResult;
 use PhpSchool\PhpWorkshop\Utils\ArrayObject;
-use PhpSchool\PhpWorkshopTest\Asset\ResultResultAggregator;
 use PHPUnit_Framework_TestCase;
 use PhpSchool\PhpWorkshop\Result\Failure;
 use PhpSchool\PhpWorkshop\Result\Success;
diff --git a/test/UserStateSerializerTest.php b/test/UserStateSerializerTest.php
@@ -2,7 +2,6 @@
 
 namespace PhpSchool\PhpWorkshopTest;
 
-use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
 use PhpSchool\PhpWorkshop\ExerciseRepository;
 use PhpSchool\PhpWorkshop\UserState;

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class GenericFailure extends Failure implements FailureInterface`
`24`	`24`
`25`	`25`	`/**`
`26`	`26`	`* @param RequestInterface $request The request that caused the failure.`
`27`		`- * @param null $reason`
	`27`	`+ * @param string\|null $reason`
`28`	`28`	`*/`
`29`	`29`	`public function __construct(RequestInterface $request, $reason = null)`
`30`	`30`	`{`