Updated travis config (#1)

* Updated travis config

* Added tests

Author: Nyholm

.travis.yml

@@ -22,8 +22,19 @@ env:
     - SYMFONY_VERSION=3.2.*
     - SYMFONY_VERSION=2.7.*
 
+matrix:
+  fast_finish: true
+  include:
+    - php: 5.5
+      env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" COVERAGE=true TEST_COMMAND="composer test-ci" SYMFONY_VERSION=2.7.*
+
 install:
-    - travis_retry composer update --prefer-dist --no-interaction
+    - composer require symfony/symfony:${SYMFONY_VERSION} --no-update
+    - travis_retry composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
 
 script:
     - $TEST_COMMAND
+
+after_success:
+    - if [[ $COVERAGE = true ]]; then wget https://scrutinizer-ci.com/ocular.phar; fi
+    - if [[ $COVERAGE = true ]]; then php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml; fi

composer.json

@@ -10,11 +10,12 @@
     ],
     "require": {
         "php": "^5.5 || ^7.0",
-        "php-translation/common": "^0.1",
+        "php-translation/common": "^0.2.1",
         "symfony/translation": "^2.7 || ^3.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^4.5 || ^5.4"
+        "phpunit/phpunit": "^4.5 || ^5.4",
+        "symfony/framework-bundle": "^2.7 || ^3.0"
     },
     "autoload": {
         "psr-4": {

src/FileStorage.php

@@ -55,6 +55,10 @@ public function __construct(TranslationWriter $writer, $loader, array $dir)
             throw new \LogicException('Second parameter of FileStorage must be a Symfony translation loader or implement Translation\SymfonyStorage\TranslationLoader');
         }
 
+        if (empty($dir)) {
+            throw new \LogicException('Third parameter of FileStorage cannot be empty');
+        }
+
         $this->writer = $writer;
         $this->loader = $loader;
         $this->dir = $dir;

tests/FileStorageTest.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Translation\SymfonyStorage\Tests;
+
+use Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader;
+use Symfony\Component\Translation\Writer\TranslationWriter;
+use Translation\SymfonyStorage\FileStorage;
+
+class FileStorageTest extends \PHPUnit_Framework_TestCase
+{
+    public function testConstructor()
+    {
+        $storage = new FileStorage(new TranslationWriter(), new TranslationLoader(), ['foo']);
+    }
+
+    /**
+     * @expectedException \LogicException
+     */
+    public function testConstructorInvalidLoader()
+    {
+        $storage = new FileStorage(new TranslationWriter(), new TranslationWriter(), ['foo']);
+    }
+
+    /**
+     * @expectedException \LogicException
+     */
+    public function testConstructorEmptyArray()
+    {
+        $storage = new FileStorage(new TranslationWriter(), new TranslationLoader(), []);
+    }
+}