ext/soap/php_http.c: Refactor in_domain()

Girgias · Girgias · commit 2f0643dbc571 · 2025-07-07T15:31:31.000+01:00
diff --git a/ext/soap/php_http.c b/ext/soap/php_http.c
@@ -326,9 +326,9 @@ static bool in_domain(const zend_string *host, const zend_string *domain)
 {
 	if (ZSTR_VAL(domain)[0] == '.') {
 		if (ZSTR_LEN(host) > ZSTR_LEN(domain)) {
-			return strcmp(ZSTR_VAL(host)+ZSTR_LEN(host)-ZSTR_LEN(domain), ZSTR_VAL(domain)) == 0;
+			return zend_string_equals_cstr(domain, ZSTR_VAL(host)+ZSTR_LEN(host)-ZSTR_LEN(domain), ZSTR_LEN(domain));
 		} else {
-			return 0;
+			return false;
 		}
 	} else {
 		return zend_string_equals(host,domain);

Original file line number	Diff line number	Diff line change
`@@ -326,9 +326,9 @@ static bool in_domain(const zend_string host, const zend_string domain)`
`326`	`326`	`{`
`327`	`327`	`if (ZSTR_VAL(domain)[0] == '.') {`
`328`	`328`	`if (ZSTR_LEN(host) > ZSTR_LEN(domain)) {`
`329`		`- return strcmp(ZSTR_VAL(host)+ZSTR_LEN(host)-ZSTR_LEN(domain), ZSTR_VAL(domain)) == 0;`
	`329`	`+ return zend_string_equals_cstr(domain, ZSTR_VAL(host)+ZSTR_LEN(host)-ZSTR_LEN(domain), ZSTR_LEN(domain));`
`330`	`330`	`} else {`
`331`		`- return 0;`
	`331`	`+ return false;`
`332`	`332`	`}`
`333`	`333`	`} else {`
`334`	`334`	`return zend_string_equals(host,domain);`