Skip to content

Commit 56308f6

Browse files
authored
ext/standard/password: Use zend_string_efree() where possible (#19150)
1 parent a8a3c81 commit 56308f6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ext/standard/password.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,18 @@ static zend_string* php_password_make_salt(size_t length) /* {{{ */
8686
buffer = zend_string_alloc(length * 3 / 4 + 1, 0);
8787
if (FAILURE == php_random_bytes_throw(ZSTR_VAL(buffer), ZSTR_LEN(buffer))) {
8888
zend_value_error("Unable to generate salt");
89-
zend_string_release_ex(buffer, 0);
89+
zend_string_efree(buffer);
9090
return NULL;
9191
}
9292

9393
ret = zend_string_alloc(length, 0);
9494
if (php_password_salt_to64(ZSTR_VAL(buffer), ZSTR_LEN(buffer), length, ZSTR_VAL(ret)) == FAILURE) {
9595
zend_value_error("Generated salt too short");
96-
zend_string_release_ex(buffer, 0);
97-
zend_string_release_ex(ret, 0);
96+
zend_string_efree(buffer);
97+
zend_string_efree(ret);
9898
return NULL;
9999
}
100-
zend_string_release_ex(buffer, 0);
100+
zend_string_efree(buffer);
101101
ZSTR_VAL(ret)[length] = 0;
102102
return ret;
103103
}

0 commit comments

Comments
 (0)