poll: make Handle::getFileDescriptor abstract

Author: bukka

ext/standard/io_poll.c

@@ -435,20 +435,6 @@ PHP_METHOD(Io_Poll_Backend, supportsEdgeTriggering)
 	RETURN_BOOL(php_poll_backend_supports_edge_triggering(type));
 }
 
-PHP_METHOD(Io_Poll_Handle, getFileDescriptor)
-{
-	ZEND_PARSE_PARAMETERS_NONE();
-
-	php_poll_handle_object *intern = PHP_POLL_HANDLE_OBJ_FROM_ZV(getThis());
-	php_socket_t fd = php_poll_handle_get_fd(intern);
-
-	if (fd == SOCK_ERR) {
-		RETURN_LONG(0);
-	}
-
-	RETURN_LONG((zend_long) fd);
-}
-
 PHP_METHOD(StreamPollHandle, __construct)
 {
 	php_stream *stream;
@@ -491,6 +477,20 @@ PHP_METHOD(StreamPollHandle, isValid)
 	RETURN_BOOL(intern->ops->is_valid(intern));
 }
 
+PHP_METHOD(StreamPollHandle, getFileDescriptor)
+{
+	ZEND_PARSE_PARAMETERS_NONE();
+
+	php_poll_handle_object *intern = PHP_POLL_HANDLE_OBJ_FROM_ZV(getThis());
+	php_socket_t fd = php_poll_handle_get_fd(intern);
+
+	if (fd == SOCK_ERR) {
+		RETURN_LONG(0);
+	}
+
+	RETURN_LONG((zend_long) fd);
+}
+
 PHP_METHOD(Io_Poll_Watcher, __construct)
 {
 	zend_throw_error(NULL, "Cannot directly construct Watcher, use Context::add");

ext/standard/io_poll.stub.php

@@ -36,7 +36,7 @@ enum Event {
 
     abstract class Handle
     {
-        protected function getFileDescriptor(): int {}
+        abstract protected function getFileDescriptor(): int;
     }
 
     final class Watcher
@@ -141,5 +141,7 @@ public function __construct($stream) {}
         public function getStream() {}
 
         public function isValid(): bool {}
+
+        protected function getFileDescriptor(): int {}
     }
 }