ext/random: Remove useless variable

Girgias · Girgias · commit b43bfd8c481e · 2025-04-26T13:50:28.000+01:00
diff --git a/ext/random/random.c b/ext/random/random.c
@@ -525,9 +525,8 @@ PHP_FUNCTION(mt_srand)
 PHP_FUNCTION(mt_rand)
 {
 	zend_long min, max;
-	int argc = ZEND_NUM_ARGS();
 
-	if (argc == 0) {
+	if (ZEND_NUM_ARGS() == 0) {
 		/* genrand_int31 in mt19937ar.c performs a right shift */
 		RETURN_LONG(php_mt_rand() >> 1);
 	}
@@ -563,9 +562,8 @@ PHP_FUNCTION(mt_getrandmax)
 PHP_FUNCTION(rand)
 {
 	zend_long min, max;
-	int argc = ZEND_NUM_ARGS();
 
-	if (argc == 0) {
+	if (ZEND_NUM_ARGS() == 0) {
 		/* genrand_int31 in mt19937ar.c performs a right shift */
 		RETURN_LONG(php_mt_rand() >> 1);
 	}

Original file line number	Diff line number	Diff line change
`@@ -525,9 +525,8 @@ PHP_FUNCTION(mt_srand)`
`525`	`525`	`PHP_FUNCTION(mt_rand)`
`526`	`526`	`{`
`527`	`527`	`zend_long min, max;`
`528`		`- int argc = ZEND_NUM_ARGS();`
`529`	`528`
`530`		`- if (argc == 0) {`
	`529`	`+ if (ZEND_NUM_ARGS() == 0) {`
`531`	`530`	`/* genrand_int31 in mt19937ar.c performs a right shift */`
`532`	`531`	`RETURN_LONG(php_mt_rand() >> 1);`
`533`	`532`	`}`
`@@ -563,9 +562,8 @@ PHP_FUNCTION(mt_getrandmax)`
`563`	`562`	`PHP_FUNCTION(rand)`
`564`	`563`	`{`
`565`	`564`	`zend_long min, max;`
`566`		`- int argc = ZEND_NUM_ARGS();`
`567`	`565`
`568`		`- if (argc == 0) {`
	`566`	`+ if (ZEND_NUM_ARGS() == 0) {`
`569`	`567`	`/* genrand_int31 in mt19937ar.c performs a right shift */`
`570`	`568`	`RETURN_LONG(php_mt_rand() >> 1);`
`571`	`569`	`}`