Insert tests

Author: phpfui

.gitignore

@@ -3,6 +3,6 @@ vendor/
 bin/
 composer.lock
 .php-cs-fixer.cache
-.phpunit.result.cache
+.phpunit.cache
 phpunit.xml
 

README.md

@@ -1,21 +1,23 @@
-# PHPFUI\ORM [![Tests](https://github.com/phpfui/ORM/actions/workflows/tests.yml/badge.svg)](https://github.com/phpfui/ORM/actions?query=workflow%3Atests) [![Latest Packagist release](https://img.shields.io/packagist/v/phpfui/ORM.svg)](https://packagist.org/packages/phpfui/ORM) ![](https://img.shields.io/badge/PHPStan-level%206-brightgreen.svg?style=flat)
+# PHPFUI\ORM [![Tests](https://github.com/phpfui/ORM/actions/workflows/tests.yml/badge.svg)](https://github.com/phpfui/ORM/actions?query=workflow%3Atests) [![Latest Packagist release](https://img.shields.io/packagist/v/phpfui/ORM.svg)](https://packagist.org/packages/phpfui/ORM) ![](https://img.shields.io/badge/PHPStan-level%205-brightgreen.svg?style=flat)
 
 ### PHPFUI\ORM a minimal Object Relational Mapper (ORM) for MySQL, MariaDB and SQLite3
 Why another PHP ORM? In writing minimal and fast websites, it was determined that existing PHP ORM solutions were overly complex. **PHPFUI\ORM** is less than 6k lines of code in under 50 files.  It is designed to have a minimal memory footprint and excellent execution times for most database needs.
 
 **PHPFUI\ORM** is not an attempt to write an abstraction around SQL as other ORMs do, rather it is a way to work with SQL that closely matches the semantics of SQL, with the power of PHP objects.  It allows PHP to manipulate SQL queries without having to write SQL in plain text. This is very useful for queries generated via user interfaces where the user is given a lot of flexability in how a query is defined.
 
 ## Features
-- **Active Records** that present a fully type checked object interface and implement basic CRUD functionality.
-- **Active Tables** for full table operations including support for where, having, limits, ordering, grouping, joins and unions.
-- **Data Cursors** that implement **iterable** and **Countable** eliminating the need for full arrays read into memory.
-- **Validation** for fully customizable and translatable backend validation.
-- **Virtual Fields** for get and set semantics.
-- **Migrations** simple migrations offer atomic up and down migrations.
-- **Relations** for parent, children, one to one, many to many, and custom relationships.
-- **Type Safe** to prevent stupid type errors.
-- **Raw SQL Query Support** execute any valid SQL command.
-- **MultiDatabase Support** built on PDO with support for MySQL, MariaDB and SQLite.
+- **Active Records** A fully type checked object interface and implement basic CRUD functionality.
+- **Active Tables** Full table operations including support for where, having, limits, ordering, grouping, joins and unions.
+- **Data Cursors** Cursors implement **iterable** and **Countable** eliminating the need for full arrays read into memory.
+- **Validation** Fully customizable and translatable backend validation.
+- **Virtual Fields** Supports get and set semantics for any custom or calculated field.
+- **Migrations** Simple migrations offer atomic up and down migrations.
+- **Relations** Parent, children, one to one, many to many, and custom relationships.
+- **Transactions** Object based transaction meaning exceptions can not leave an open transacton.
+- **Type Safe** Prevent stupid type errors.
+- **Raw SQL Query Support** Execute any valid SQL command.
+- **Multiple Database Support** Work with multiple databases simultaneously.
+- **Multi-Vendor Support** Built on PDO with support for MySQL, MariaDB and SQLite.
 
 ## Usage
 ### Setup
@@ -108,13 +110,12 @@ Exceptions are generated in the following conditions:
 - Incorrect type for Operator (must be an array for **IN** for example)
 - Passing an incorrect type as a primary key
 - Invalid join type
-- Requesting a **RecordCursor** with a table join
 - Joining on an invalid table
 
 All of the above exceptions are programmer errors and strictly enforced. Empty queries are not considered errors. SQL may also return [Exceptions](https://www.php.net/manual/en/class.exception.php) if invalid fields are used.
 
 ### Type Conversions
-If you set a field to the wrong type, the library logs an error then converts the type via the appropriate PHP cast.
+If you set a field to the wrong type, the library logs an warning then converts the type via the appropriate PHP cast.
 
 ## Multiple Database Support
 While this is primarily a single database ORM, you can switch databases at run time. Save the value from `$connectionId = \PHPFUI\ORM::addConnection($pdo);` and then call `\PHPFUI\ORM::useConnection($db);` to switch.  `\PHPFUI\ORM::addConnection` will set the current connection.
@@ -155,7 +156,8 @@ foreach ($cursors as $cursor)
 + [Migrations](<https://github.com/phpfui/ORM/blob/main/docs/6. Migrations.md>)
 + [Validation](<https://github.com/phpfui/ORM/blob/main/docs/7. Validation.md>)
 + [Translations](<https://github.com/phpfui/ORM/blob/main/docs/8. Translations.md>)
-+ [Miscellaneous](<https://github.com/phpfui/ORM/blob/main/docs/9. Miscellaneous.md>)
++ [Transactions](<https://github.com/phpfui/ORM/blob/main/docs/9. Transactions.md>)
++ [Miscellaneous](<https://github.com/phpfui/ORM/blob/main/docs/10. Miscellaneous.md>)
 
 ## Full Class Documentation
 [PHPFUI/ORM](http://phpfui.com/?n=PHPFUI\ORM)

Tests/Unit/DeleteTest.php

@@ -8,26 +8,26 @@ public function testRecordDelete() : void
 		{
 		$table = new \Tests\App\Table\Customer();
 		$this->assertEquals(29, $table->count());
-		$this->assertTrue(\PHPFUI\ORM::beginTransaction());
+		$transaction = new \PHPFUI\ORM\Transaction();
 		$customer = new \Tests\App\Record\Customer(9);
 		$this->assertEquals('Company I', $customer->company);
 		$customer->delete();
 		$this->assertEquals(28, $table->count());
-		$this->assertTrue(\PHPFUI\ORM::rollBack());
+		$this->assertTrue($transaction->rollBack());
 		$this->assertEquals(29, $table->count());
 		}
 
 	public function testTableDelete() : void
 		{
 		$table = new \Tests\App\Table\Customer();
 		$this->assertEquals(29, $table->count());
-		$this->assertTrue(\PHPFUI\ORM::beginTransaction());
+		$transaction = new \PHPFUI\ORM\Transaction();
 		$table->setWhere(new \PHPFUI\ORM\Condition('customer_id', 9));
 		$table->delete();
 		$this->assertEquals(0, $table->count());
 		$table = new \Tests\App\Table\Customer();
 		$this->assertEquals(28, $table->count());
-		$this->assertTrue(\PHPFUI\ORM::rollBack());
+		$this->assertTrue($transaction->rollBack());
 		$this->assertEquals(29, $table->count());
 		}
 	}

Tests/Unit/InsertTest.php

@@ -4,6 +4,61 @@
 
 class InsertTest extends \PHPUnit\Framework\TestCase
 	{
+	public function testStringNullInsert() : void
+		{
+		$transaction = new \PHPFUI\ORM\Transaction();
+		$test = new \Tests\App\Record\StringRecord();
+		$test->stringRequired = $required = 'required';
+		$id = $test->insert();
+		$this->assertGreaterThan(0, $id);
+		$insertedTest = new \Tests\App\Record\StringRecord($id);
+		$this->assertNull($insertedTest->stringDefaultNull);
+		$this->assertEquals($required, $insertedTest->stringRequired);
+		$this->assertEquals('default', $insertedTest->stringDefaultNullable);
+		$this->assertEquals('default', $insertedTest->stringDefaultNotNull);
+		$this->assertTrue($transaction->rollBack());
+		}
+
+	public function testRequiredStringNotSetInsert() : void
+		{
+		$this->expectException(\Exception::class);
+		$transaction = new \PHPFUI\ORM\Transaction();
+		$test = new \Tests\App\Record\StringRecord();
+		$id = $test->insert();
+		$this->assertTrue($transaction->rollBack());
+		}
+
+	public function testDateNullInsert() : void
+		{
+		$transaction = new \PHPFUI\ORM\Transaction();
+		$test = new \Tests\App\Record\DateRecord();
+		$test->dateRequired = $date = \date('Y-m-d');
+		$timeStamp = \date('Y-m-d H:i:s');
+		$id = $test->insert();
+		$insertedTest = new \Tests\App\Record\DateRecord($id);
+		$this->assertNull($insertedTest->dateDefaultNull);
+		$this->assertEquals($date, $insertedTest->dateRequired);
+		$this->assertEquals('2000-01-02', $insertedTest->dateDefaultNullable);
+		$this->assertEquals('2000-01-02', $insertedTest->dateDefaultNotNull);
+		$this->assertGreaterThanOrEqual($timeStamp, $insertedTest->timestampDefaultCurrentNullable);
+		$this->assertGreaterThanOrEqual($timeStamp, $insertedTest->timestampDefaultCurrentNotNull);
+
+		$this->assertTrue($transaction->rollBack());
+		}
+
+	public function testDateRequiredInsert() : void
+		{
+		$this->expectException(\Exception::class);
+		$transaction = new \PHPFUI\ORM\Transaction();
+		$test = new \Tests\App\Record\DateRecord();
+		$id = $test->insert();
+		$insertedTest = new \Tests\App\Record\DateRecord($id);
+		$this->assertNull($insertedTest->dateDefaultNull);
+		$this->assertEquals('2000-01-02', $insertedTest->dateDefaultNullable);
+		$this->assertEquals('2000-01-02', $insertedTest->dateDefaultNotNull);
+		$this->assertTrue($transaction->rollBack());
+		}
+
 	public function testRecordInsert() : void
 		{
 		$customer = new \Tests\App\Record\Customer();
@@ -25,10 +80,10 @@ public function testRecordInsert() : void
 
 		$table = new \Tests\App\Table\Customer();
 		$this->assertEquals(29, $table->count());
-		$this->assertTrue(\PHPFUI\ORM::beginTransaction());
+		$transaction = new \PHPFUI\ORM\Transaction();
 		$this->assertEquals(30, $customer->insert());
 		$this->assertEquals(30, $table->count());
-		$this->assertTrue(\PHPFUI\ORM::rollBack());
+		$this->assertTrue($transaction->rollBack());
 		$this->assertEquals(29, $table->count());
 		}
 
@@ -39,7 +94,7 @@ public function testRelatedInsert() : void
 		$orderTable = new \Tests\App\Table\Order();
 		$this->assertEquals(48, $orderTable->count());
 
-		$this->assertTrue(\PHPFUI\ORM::beginTransaction());
+		$transaction = new \PHPFUI\ORM\Transaction();
 
 		$customer = new \Tests\App\Record\Customer();
 		$customer->address = '123 Broadway';
@@ -89,7 +144,7 @@ public function testRelatedInsert() : void
 		$orderTable->setWhere(new \PHPFUI\ORM\Condition('notes', 'Test Order'));
 		$foundOrder = $orderTable->getRecordCursor()->current();
 
-		$this->assertTrue(\PHPFUI\ORM::rollBack());
+		$this->assertTrue($transaction->rollBack());
 		$this->assertEquals(29, $customerTable->count());
 		$orderTable->setWhere();
 		$this->assertEquals(48, $orderTable->count());

Tests/Unit/UpdateTest.php

@@ -19,7 +19,7 @@ public function testRecordUpdate() : void
 		$customerTable2->setWhere($condition2);
 		$this->assertEquals(1, $customerTable2->count());
 
-		$this->assertTrue(\PHPFUI\ORM::beginTransaction());
+		$transaction = new \PHPFUI\ORM\Transaction();
 		$customer = new \Tests\App\Record\Customer(15);
 		$this->assertEquals('Helena', $customer->first_name);
 		$this->assertEquals('Kupkova', $customer->last_name);
@@ -29,7 +29,7 @@ public function testRecordUpdate() : void
 		$this->assertEquals(1, $customerTable->count());
 		$this->assertEquals(0, $customerTable2->count());
 
-		$this->assertTrue(\PHPFUI\ORM::rollBack());
+		$this->assertTrue($transaction->rollBack());
 		$this->assertEquals(0, $customerTable->count());
 		$this->assertEquals(1, $customerTable2->count());
 		$customerTable->setWhere();

Tests/bootstrap.php

@@ -25,7 +25,7 @@ function autoload(string $className) : void
 	{
 	if ($fileinfo->isFile() && \str_ends_with($fileinfo->getRealPath(), '.php'))
 		{
-	\unlink($fileinfo->getRealPath());
+		\unlink($fileinfo->getRealPath());
 		}
 	}
 

bootstrap.php

@@ -16,7 +16,7 @@
         "phpfui/translation": "^1.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.0",
+        "phpunit/phpunit": "^10.0",
         "phpfui/phpunit-syntax-coverage": "^1.0",
         "roave/security-advisories": "dev-latest",
         "friendsofphp/php-cs-fixer": "^3.0",

composer.json

@@ -46,6 +46,3 @@ The following namespaces are used in production but contains support classes or
 - **PHPFUI\ORM\Tool** used by model generation
 - **PHPFUI\ORM\Record** contains example of migration table.
 - **PHPFUI\ORM\Table** contains example of migration table.
-
-
-

docs/9. Miscellaneous.md renamed to docs/10. Miscellaneous.md

@@ -131,8 +131,13 @@ $order->insert();
 ```
 Notice that we did not have to save the customer record.  By assigning it to the order record, it was automatically saved to generate the required primary key value. The related record is not saved if it already has been assigned a primary key, it is your responsiblity to save it if you changed an existing record.
 
-### Alternate way to set related records
+### Alternate Way To Set Related Records
 You can always just assign the id's directly: `$orderDetail->purchase_order_id = $purchase_order->purchase_order_id;`. Saving the OrderDetail record is up to you.
 
 ### Other Types Of Related Records
 See [Virtual Fields](<https://github.com/phpfui/ORM/blob/main/docs/5. Virtual Fields.md>) for information on how to impliment child or many to many relationships.
+
+### Multi Database Support
+Related Records will always return a record from the currently selected database. Care must be taken when using multiple databases that any references to related records are done while the correct database instance is active. Cursors will continue to use the database in effect when they were created.
+
+A future version of this libray may offer better multi database support.