Add more test coverage for error message

Author: blakeembrey

src/cases.spec.ts

@@ -53,6 +53,17 @@ export const PARSER_TESTS: ParserTestSet[] = [
       "/:test",
     ),
   },
+  {
+    path: "/:a:b",
+    expected: new TokenData(
+      [
+        { type: "text", value: "/" },
+        { type: "param", name: "a" },
+        { type: "param", name: "b" },
+      ],
+      "/:a:b",
+    ),
+  },
   {
     path: '/:"0"',
     expected: new TokenData(

src/index.spec.ts

@@ -1,5 +1,12 @@
 import { describe, it, expect } from "vitest";
-import { parse, compile, match, stringify } from "./index.js";
+import {
+  parse,
+  compile,
+  match,
+  stringify,
+  pathToRegexp,
+  TokenData,
+} from "./index.js";
 import {
   PARSER_TESTS,
   COMPILE_TESTS,
@@ -19,6 +26,7 @@ describe("path-to-regexp", () => {
         ),
       );
     });
+
     it("should throw on nested unbalanced group", () => {
       expect(() => parse("/{:foo/{x,y}")).toThrow(
         new TypeError(
@@ -94,6 +102,49 @@ describe("path-to-regexp", () => {
     });
   });
 
+  describe("pathToRegexp errors", () => {
+    it("should throw when missing text between params", () => {
+      expect(() => pathToRegexp("/:foo:bar")).toThrow(
+        new TypeError(
+          'Missing text before "bar": /:foo:bar; visit https://git.new/pathToRegexpError for more info',
+        ),
+      );
+    });
+
+    it("should throw when missing text between params using TokenData", () => {
+      expect(() =>
+        pathToRegexp(
+          new TokenData([
+            { type: "param", name: "a" },
+            { type: "param", name: "b" },
+          ]),
+        ),
+      ).toThrow(
+        new TypeError(
+          'Missing text before "b"; visit https://git.new/pathToRegexpError for more info',
+        ),
+      );
+    });
+
+    it("should throw with `originalPath` when missing text between params using TokenData", () => {
+      expect(() =>
+        pathToRegexp(
+          new TokenData(
+            [
+              { type: "param", name: "a" },
+              { type: "param", name: "b" },
+            ],
+            "/[a][b]",
+          ),
+        ),
+      ).toThrow(
+        new TypeError(
+          'Missing text before "b": /[a][b]; visit https://git.new/pathToRegexpError for more info',
+        ),
+      );
+    });
+  });
+
   describe.each(PARSER_TESTS)(
     "parse $path with $options",
     ({ path, options, expected }) => {

src/index.ts

@@ -604,7 +604,7 @@ function toRegExp(
     if (token.type === "param" || token.type === "wildcard") {
       if (!isSafeSegmentParam && !backtrack) {
         throw new TypeError(
-          errorMessage(`Missing text after "${token.name}"`, originalPath),
+          errorMessage(`Missing text before "${token.name}"`, originalPath),
         );
       }