Merge pull request #246 from pimutils/warnings

Clean up warnings

Author: Hugo Osvaldo Barrera

tests/test_config.py

@@ -31,7 +31,8 @@ def test_xdg_nonexistant(runner):
 
 def test_xdg_existant(runner, tmpdir, config):
     with tmpdir.mkdir('todoman').join('todoman.conf').open('w') as f:
-        f.write(config.open().read())
+        with config.open() as c:
+            f.write(c.read())
 
     with patch('xdg.BaseDirectory.xdg_config_dirs', [str(tmpdir)]):
         result = CliRunner().invoke(

todoman/cli.py

@@ -36,9 +36,8 @@ def wrapper(*a, **kw):
 with_id_arg = click.argument('id', type=click.IntRange(min=TODO_ID_MIN))
 
 
-def _validate_lists_param(ctx, param=None, lists=None):
-    if lists:
-        return [_validate_list_param(ctx, name=l) for l in lists]
+def _validate_lists_param(ctx, param=None, lists=[]):
+    return [_validate_list_param(ctx, name=l) for l in lists]
 
 
 def _validate_list_param(ctx, param=None, name=None):

todoman/formatters.py

@@ -24,7 +24,9 @@ def __init__(self, date_format='%Y-%m-%d', time_format='%H:%M',
         self.tz = tz_override or tzlocal()
         self.now = datetime.datetime.now().replace(tzinfo=self.tz)
 
-        self._parsedatetime_calendar = parsedatetime.Calendar()
+        self._parsedatetime_calendar = parsedatetime.Calendar(
+            version=parsedatetime.VERSION_CONTEXT_STYLE,
+        )
 
     def simple_action(self, action, todo):
         return '{} "{}"'.format(action, todo.summary)
@@ -158,11 +160,9 @@ def _parse_datetime_naive(self, dt):
         except ValueError:
             pass
 
-        rv, certainty = self._parsedatetime_calendar.parse(dt)
-        if not certainty:
-            raise ValueError(
-                'Time description not recognized: {}' .format(dt)
-            )
+        rv, pd_ctx = self._parsedatetime_calendar.parse(dt)
+        if not pd_ctx.hasDateOrTime:
+            raise ValueError('Time description not recognized: {}' .format(dt))
         return datetime.datetime.fromtimestamp(mktime(rv))
 
     def format_database(self, database):

todoman/interactive.py

@@ -47,15 +47,15 @@ def __init__(self, todo, lists, formatter):
         grid = urwid.Pile(pile_items)
         spacer = urwid.Divider()
 
-        self.left_column = urwid.ListBox([
+        self.left_column = urwid.ListBox(urwid.SimpleListWalker([
             grid,
             spacer,
             self._status,
             buttons,
-        ])
-        right_column = urwid.ListBox(
+        ]))
+        right_column = urwid.ListBox(urwid.SimpleListWalker(
             [urwid.Text('List:\n')] + self.list_selector
-        )
+        ))
 
         self._ui = urwid.Columns([self.left_column, right_column])