Audrey feedback

Author: jhamon

.github/workflows/alpha-release.yaml

@@ -24,22 +24,22 @@ on:
         default: 'rc1'
 
 jobs:
-  # unit-tests:
-  #   uses: './.github/workflows/testing-unit.yaml'
-  #   secrets: inherit
-  # integration-tests:
-  #     uses: './.github/workflows/testing-integration.yaml'
-  #     secrets: inherit
-  # dependency-tests:
-  #   uses: './.github/workflows/testing-dependency.yaml'
-  #   secrets: inherit
+  unit-tests:
+    uses: './.github/workflows/testing-unit.yaml'
+    secrets: inherit
+  integration-tests:
+      uses: './.github/workflows/testing-integration.yaml'
+      secrets: inherit
+  dependency-tests:
+    uses: './.github/workflows/testing-dependency.yaml'
+    secrets: inherit
 
   pypi:
     uses: './.github/workflows/publish-to-pypi.yaml'
-    # needs: 
-    #   - unit-tests
-    #   - integration-tests
-    #   - dependency-tests
+    needs: 
+      - unit-tests
+      - integration-tests
+      - dependency-tests
     with:
       isPrerelease: true
       ref: ${{ inputs.ref }}

CONTRIBUTING.md

@@ -150,7 +150,7 @@ These instructions can only be followed by Pinecone employees with access to our
 
 Prerequisites:
 - You must be an employee with access to private Pinecone repositories
-- You must have [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running. Our code generation script uses a dockerized version of the openapi CLI.
+- You must have [Docker Desktop](https://www.docker.com/products/docker-desktop/) installed and running. Our code generation script uses a dockerized version of the OpenAPI CLI.
 - You must have initialized the git submodules under codegen
 
 ```sh

codegen/build-oas.sh

@@ -33,9 +33,9 @@ update_apis_repo() {
 update_templates_repo() {
 	echo "Updating templates repo"
 	pushd codegen/python-oas-templates
-		# git fetch
-		# git checkout main
-		# git pull
+		git fetch
+		git checkout main
+		git pull
 	popd
 }
 

codegen/python-oas-templates

@@ -51,7 +51,7 @@ def start_import(
     ) -> StartImportResponse:
         """Import data from a storage provider into an index. The uri must start with the scheme of a supported
         storage provider. For buckets that are not publicly readable, you will also need to separately configure
-        a storage integration and pass the integration name.
+        a storage integration and pass the integration id.
 
         Examples:
             >>> from pinecone import Pinecone
@@ -61,7 +61,7 @@ def start_import(
 
         Args:
             uri (str): The URI of the data to import. The URI must start with the scheme of a supported storage provider.
-            integration (Optional[str], optional): If your bucket requires authentication to access, you need to pass the name of your storage integration using this property. Defaults to None.
+            integration_id (Optional[str], optional): If your bucket requires authentication to access, you need to pass the id of your storage integration using this property. Defaults to None.
             error_mode: Defaults to "CONTINUE". If set to "CONTINUE", the import operation will continue even if some
                 records fail to import. Pass "ABORT" to stop the import operation if any records fail to import.
 
@@ -103,7 +103,7 @@ def list_imports(self, **kwargs) -> Iterator[List[ImportModel]]:
         ```
 
         You should be cautious with this approach because it will fetch all operations at once, which could be a large number
-        network calls and a lot of memory to hold the results.
+        of network calls and a lot of memory to hold the results.
 
         Args:
             limit (Optional[int]): The maximum number of operations to fetch in each network call. If unspecified, the server will use a default value. [optional]
@@ -179,7 +179,6 @@ def describe_import(self, id: str) -> ImportModel:
         """
         if isinstance(id, int):
             id = str(id)
-
         return self.__import_operations_api.describe_import(id=id)
 
     def cancel_import(self, id: str):