Keywords Vocabulary, not persisting source&identifier on submission wizard reload

[jardakotesovec]

Description

If I use vocabulary from plugin for keywords. I can add items from vocabulary and the vocabulary details (identifier, source) gets saved just fine. But if I don't finish that submission and get back to it later or if I just reload the submission wizard in browser. I will loose the information about identifier and source. This works correctly on the Publication->Metadata page.

Issue is probably on the form creation step, where this information is not carried over.

Steps to Reproduce

First install and enable frascati plugin, for example this one - https://github.com/asmecher/frascati
.
2. Login as Author
3. Start new Submission
4. Enter the keywords from the vocabulary (they should show up in the autocomplete) and save the form by going to the next step
5. In database (table controlled_vocab_entry_settings) they are saved with the identifier&source details
6. Reload the page with the submission wizard, save the keywords again by adding new keyword and going to the next step
7. Check the controlled_vocab_entry_settings, which has no identifier&source anymore for the initially added keywords

Expected Result

To keep the identifier&source after keyword editing in the database.

Actual Result

Only name gets saved, after returning to the submission process.

Environment Details

No response

Application Version

OJS, OMP, OPS 3.5

Logs

No response

Additional Information

No response

PRs

Stable-3.5.0

pkp-lib --> #11522
ojs --> pkp/ojs#4935 [TEST ONLY]
omp --> pkp/omp#2031 [TEST ONLY]
ops -> pkp/ops#1014 [TEST ONLY]

[Tribunal33]

I'm not sure if this is related but I just happened to come across it the other day and sounds familiar with not persisting the data.

When making a submission if you select one of the links to review the policies it loads the page you are on. When you select browser back button all of the radio buttons, checkboxes except for the Title of the submission. If you fill it in an try to Begin Submission all of the required warning messages popup even though all the radio buttons and checkboxes are already selected.

Steps to reproduce

1. Start a submission
2. Select Author Guidelines or Submission Guidelines link
3. Select browser back button
4. Fill in missing title
5. Select Begin Submission button

Expected: I would expect that the information persists if the page loads in the same tab. Including the title. When Selecting Begin Submission the form should validate the form options and correctly identify if they have been selected.

Actual: The form reloads with options selected but the validation is not able to correctly identify if they have been selected. Instead it shows a warning and the Title field is empty.

[Tribunal33]

Ignore my previous comment. It appears to be a different issue. I have moved this to #11482

[jardakotesovec]

Came across another scenario where the identifier&source is also lost - if the publication metadata gets updated. Just updating title for example in publication-> Title&Abstract

Maybe its exactly the same root cause..

Issue is somewhere in publication/Repository.php - in edit operation

        $newPublication = Repo::publication()->newDataObject(array_merge($publication->_data, $params));

$publication->_data have only the keyword name

[asmecher]

Tagging @touhidurabir -- @ajnyga is on vacation.

[ajnyga]

Thanks, I will tag @jyhein as well

[jyhein]

Source and identifier are not stored in the publication object. They need to be loaded from the db, like in the pkpmetadataform.php. Can the ui reload the form when changes happen so that the source and identifier data can be retrieved from the db?

[jardakotesovec]

@jyhein Not sure if I described it clearly enough in my last comment. Problem is that source&identifier gets removed from the database, when the PUT /publication/publicationId endpoint gets called. Not sure if its the only problem..

[jyhein]

They get removed because "new" keywords (keywords without source & identifier) replace them. No 100% sure what happens but I guess the "new" come from the publication object (filled in the form). This is what happened when I worked the 1550, and I made the form to be refetched after hitting 'Save' in the workflow