Skip to content

Commit 54b86d7

Browse files
pkp/pkp-lib#11577 [main] [UI] Top menu items are only clickable on text (#657)
* pkp/pkp-lib#11577 Render links in full on top nav menu items * pkp/pkp-lib#11577 Move li padding to the link in top nav links * pkp/pkp-lib#11577 Add Change Language locale key
1 parent 77c0c66 commit 54b86d7

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

public/globals.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ window.pkp = {
174174
'common.attachFiles': 'Attach Files',
175175
'common.back': 'Back',
176176
'common.cancel': 'Cancel',
177+
'common.changeLanguage': 'Change Language',
177178
'common.clearSearch': 'Clear search phrase',
178179
'common.close': 'Close',
179180
'common.commaListSeparator': ', ',

src/components/TopNavActions/TopNavActions.vue

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,18 @@
5757
class="-ml-2 -mr-2 border-b border-b-light pb-2 pl-2 pr-2"
5858
>
5959
<div class="ps-2 text-base-bold leading-6 text-secondary">
60-
Change Language
60+
{{ t('common.changeLanguage') }}
6161
</div>
6262
<ul>
6363
<li
6464
v-for="locale in getSupportedLocalesList()"
6565
:key="locale.key"
6666
:class="actionLinkStyle"
6767
>
68-
<a :href="locale.href" class="block w-full no-underline">
68+
<a
69+
:href="locale.href"
70+
class="block w-full px-2 py-1 no-underline"
71+
>
6972
<Icon
7073
v-if="locale.key === currentLocale"
7174
icon="Complete"
@@ -97,12 +100,12 @@
97100
<div class="-ml-2 -mr-2 text-wrap px-2 pt-2">
98101
<ul>
99102
<li :class="actionLinkStyle">
100-
<a :href="editProfileLink" class="w-full">
103+
<a :href="editProfileLink" class="block px-2 py-1">
101104
{{ t('user.profile.editProfile') }}
102105
</a>
103106
</li>
104107
<li :class="actionLinkStyle">
105-
<a :href="signOutLink" class="w-full">
108+
<a :href="signOutLink" class="block px-2 py-1">
106109
{{
107110
_isUserLoggedInAs
108111
? t('user.logOutAs', {username: currentUser.username})
@@ -186,7 +189,7 @@ const getAnimationStyle = (buttonType) => {
186189
const actionLinkStyle = [
187190
'max-w-full cursor-pointer overflow-hidden truncate whitespace-nowrap',
188191
'rounded border border-transparent bg-transparent hover:!border-primary',
189-
'px-2 py-1 leading-6 text-primary',
192+
'leading-6 text-primary',
190193
];
191194
192195
function getSupportedLocalesList() {

0 commit comments

Comments
 (0)