From 2c6792f23733dba18ebdacc0da472fb9bcd1e462 Mon Sep 17 00:00:00 2001
From: Hafsa-Naeem <hafsanaeem321@hotmail.com>
Date: Wed, 28 May 2025 02:40:10 +0500
Subject: [PATCH] pkp/pkp-lib#10263 Relax editing metadata on published/posted
 materials

---
 .../contributors/ContributorsListPanel.vue    | 19 +++----------------
 .../GalleyManager/useGalleyManagerConfig.js   | 15 ---------------
 src/pages/workflow/WorkflowPageOJS.vue        |  2 ++
 src/pages/workflow/WorkflowPageOMP.vue        |  2 ++
 src/pages/workflow/WorkflowPageOPS.vue        |  2 ++
 .../WorkflowPublicationEditWarning.vue        | 13 +++++++++++++
 .../workflowConfigEditorialOJS.js             |  3 ++-
 .../composables/useWorkflowPermissions.js     | 15 +++++++++++----
 8 files changed, 35 insertions(+), 36 deletions(-)
 create mode 100644 src/pages/workflow/components/publication/WorkflowPublicationEditWarning.vue

diff --git a/src/components/ListPanel/contributors/ContributorsListPanel.vue b/src/components/ListPanel/contributors/ContributorsListPanel.vue
index 75854b96f..c9a8b6692 100644
--- a/src/components/ListPanel/contributors/ContributorsListPanel.vue
+++ b/src/components/ListPanel/contributors/ContributorsListPanel.vue
@@ -12,10 +12,7 @@
 						<Spinner v-if="isLoading" />
 						<template #actions>
 							<PkpButton
-								v-if="
-									publication.status !== getConstant('STATUS_PUBLISHED') &&
-									canEditPublication
-								"
+								v-if="canEditPublication"
 								icon="Sort"
 								:is-active="isOrdering"
 								:disabled="isLoading"
@@ -39,11 +36,7 @@
 								{{ t('contributor.listPanel.preview') }}
 							</PkpButton>
 							<PkpButton
-								v-if="
-									!isOrdering &&
-									publication.status !== getConstant('STATUS_PUBLISHED') &&
-									canEditPublication
-								"
+								v-if="!isOrdering && canEditPublication"
 								:disabled="isLoading"
 								@click="openAddModal"
 							>
@@ -65,13 +58,7 @@
 						{{ localize(item.affiliation) }}
 					</div>
 				</template>
-				<template
-					v-if="
-						publication.status !== getConstant('STATUS_PUBLISHED') &&
-						canEditPublication
-					"
-					#item-actions="{item}"
-				>
+				<template v-if="canEditPublication" #item-actions="{item}">
 					<template v-if="isOrdering">
 						<Orderer
 							:item-id="item.id"
diff --git a/src/managers/GalleyManager/useGalleyManagerConfig.js b/src/managers/GalleyManager/useGalleyManagerConfig.js
index c2f4d7af1..eb2b19e6b 100644
--- a/src/managers/GalleyManager/useGalleyManagerConfig.js
+++ b/src/managers/GalleyManager/useGalleyManagerConfig.js
@@ -34,12 +34,6 @@ export const GalleyManagerConfiguration = {
 		Actions.GALLEY_EDIT,
 		Actions.GALLEY_SORT,
 	],
-	actionsRequiresUnpublishedState: [
-		Actions.GALLEY_ADD,
-		Actions.GALLEY_CHANGE_FILE,
-		Actions.GALLEY_DELETE,
-		Actions.GALLEY_SORT,
-	],
 };
 
 export function useGalleyManagerConfig() {
@@ -84,15 +78,6 @@ export function useGalleyManagerConfig() {
 	function getManagerConfig({submission, publication}) {
 		const permittedActions = GalleyManagerConfiguration.actions
 			.filter((action) => {
-				if (
-					publication.value.status === pkp.const.STATUS_PUBLISHED &&
-					GalleyManagerConfiguration.actionsRequiresUnpublishedState.includes(
-						action,
-					)
-				) {
-					return false;
-				}
-
 				return true;
 			})
 			.filter((action) => {
diff --git a/src/pages/workflow/WorkflowPageOJS.vue b/src/pages/workflow/WorkflowPageOJS.vue
index 25df92228..334b256cf 100644
--- a/src/pages/workflow/WorkflowPageOJS.vue
+++ b/src/pages/workflow/WorkflowPageOJS.vue
@@ -28,6 +28,7 @@ import WorkflowPublicationVersionControl from './components/publication/Workflow
 import WorkflowChangeSubmissionLanguage from './components/publication/WorkflowChangeSubmissionLanguage.vue';
 import WorkflowPrimaryBasicMetadata from './components/primary/WorkflowPrimaryBasicMetadata.vue';
 import WorkflowSubmissionStatus from './components/primary/WorkflowSubmissionStatus.vue';
+import WorkflowPublicationEditWarning from './components/publication/WorkflowPublicationEditWarning.vue';
 import WorkflowPublicationEditDisabled from './components/publication/WorkflowPublicationEditDisabled.vue';
 
 import {useWorkflowConfigOJS as useWorkflowConfig} from './composables/useWorkflowConfig/useWorkflowConfigOJS';
@@ -65,6 +66,7 @@ const Components = markRaw({
 	WorkflowPublicationVersionControl,
 	WorkflowChangeSubmissionLanguage,
 	WorkflowSubmissionStatus,
+	WorkflowPublicationEditWarning,
 	WorkflowPublicationEditDisabled,
 });
 
diff --git a/src/pages/workflow/WorkflowPageOMP.vue b/src/pages/workflow/WorkflowPageOMP.vue
index e81cddd8f..ccafe0983 100644
--- a/src/pages/workflow/WorkflowPageOMP.vue
+++ b/src/pages/workflow/WorkflowPageOMP.vue
@@ -32,6 +32,7 @@ import WorkflowPublicationVersionControl from './components/publication/Workflow
 import WorkflowChangeSubmissionLanguage from './components/publication/WorkflowChangeSubmissionLanguage.vue';
 import WorkflowPrimaryBasicMetadata from './components/primary/WorkflowPrimaryBasicMetadata.vue';
 import WorkflowSubmissionStatus from './components/primary/WorkflowSubmissionStatus.vue';
+import WorkflowPublicationEditWarning from './components/publication/WorkflowPublicationEditWarning.vue';
 import WorkflowPublicationEditDisabled from './components/publication/WorkflowPublicationEditDisabled.vue';
 
 const props = defineProps({
@@ -66,6 +67,7 @@ const Components = markRaw({
 	WorkflowPublicationVersionControl,
 	WorkflowChangeSubmissionLanguage,
 	WorkflowSubmissionStatus,
+	WorkflowPublicationEditWarning,
 	WorkflowPublicationEditDisabled,
 	WorkflowMarketingForm,
 	WorkflowWorkTypeOMP,
diff --git a/src/pages/workflow/WorkflowPageOPS.vue b/src/pages/workflow/WorkflowPageOPS.vue
index 729af182d..b8f5abbc0 100644
--- a/src/pages/workflow/WorkflowPageOPS.vue
+++ b/src/pages/workflow/WorkflowPageOPS.vue
@@ -26,6 +26,7 @@ import WorkflowChangeSubmissionLanguage from './components/publication/WorkflowC
 import WorkflowPrimaryBasicMetadata from './components/primary/WorkflowPrimaryBasicMetadata.vue';
 import WorkflowPublicationRelationDropdownOPS from './components/publication/WorkflowPublicationRelationDropdownOPS.vue';
 import WorkflowSubmissionStatus from './components/primary/WorkflowSubmissionStatus.vue';
+import WorkflowPublicationEditWarning from './components/publication/WorkflowPublicationEditWarning.vue';
 import WorkflowPublicationEditDisabled from './components/publication/WorkflowPublicationEditDisabled.vue';
 
 const props = defineProps({
@@ -55,6 +56,7 @@ const Components = markRaw({
 	WorkflowPublicationVersionControl,
 	WorkflowChangeSubmissionLanguage,
 	WorkflowSubmissionStatus,
+	WorkflowPublicationEditWarning,
 	WorkflowPublicationEditDisabled,
 });
 
diff --git a/src/pages/workflow/components/publication/WorkflowPublicationEditWarning.vue b/src/pages/workflow/components/publication/WorkflowPublicationEditWarning.vue
new file mode 100644
index 000000000..31ce1ba83
--- /dev/null
+++ b/src/pages/workflow/components/publication/WorkflowPublicationEditWarning.vue
@@ -0,0 +1,13 @@
+<!-- file: WorkflowPublicationEditWarning.vue -->
+<template>
+	<div
+		class="bg -mx-5 -mt-5 bg-attention p-5 text-center text-base-normal text-on-dark"
+	>
+		{{ t('publication.editorEditWarning') }}
+	</div>
+</template>
+
+<script setup>
+import {useLocalize} from '@/composables/useLocalize';
+const {t} = useLocalize();
+</script>
diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js
index 7de5afac9..a03a55aff 100644
--- a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js
+++ b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js
@@ -718,7 +718,7 @@ export const PublicationConfig = {
 			const items = [];
 			if (selectedPublication.status === pkp.const.STATUS_PUBLISHED) {
 				items.push({
-					component: 'WorkflowPublicationEditDisabled',
+					component: 'WorkflowPublicationEditWarning',
 					props: {},
 				});
 			}
@@ -958,6 +958,7 @@ export const PublicationConfig = {
 					props: {
 						submission,
 						publication: selectedPublication,
+						canEdit: permissions.canEditPublication,
 					},
 				},
 			];
diff --git a/src/pages/workflow/composables/useWorkflowPermissions.js b/src/pages/workflow/composables/useWorkflowPermissions.js
index 221ebf2e3..b18a38605 100644
--- a/src/pages/workflow/composables/useWorkflowPermissions.js
+++ b/src/pages/workflow/composables/useWorkflowPermissions.js
@@ -50,10 +50,17 @@ export function useWorkflowPermissions({submission, selectedPublication}) {
 
 		canEditPublication = submission.value.canCurrentUserChangeMetadata;
 
-		if (
-			selectedPublication.value &&
-			selectedPublication.value?.status === pkp.const.STATUS_PUBLISHED
-		) {
+		const isAuthor = hasIntersection(activeStage.currentUserAssignedRoles, [
+			pkp.const.ROLE_ID_AUTHOR,
+		]);
+		// block authors from editing any version if there is a published or scheduled version
+		const hasBlockedPublication = submission.value.publications.some((p) =>
+			[pkp.const.STATUS_PUBLISHED, pkp.const.STATUS_SCHEDULED].includes(
+				p.status,
+			),
+		);
+
+		if (isAuthor && hasBlockedPublication) {
 			canEditPublication = false;
 		}