Skip to content

Commit 7a1bfff

Browse files
authored
Merge pull request #115 from adangel/fix-manual-integration-test
Fix manual integration tests
2 parents 9f4c228 + c74ed64 commit 7a1bfff

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

History.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
## Fixed Issues
88

9+
* [#115](https://github.com/pmd/pmd-regression-tester/pull/115): Fix manual integration tests
10+
911
## External Contributions
1012

1113
# 1.5.2 / 2022-10-20

test/manual_integration_tests.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ def test_case_1_single_java_rule_changed
6363
assert_equal(0, @summary[:configerrors][:new], 'found new configerrors')
6464
# Only the rule AbstractClassWithoutAbtractMethod has been executed, so the
6565
# configerrors about LoosePackageCoupling are gone, one for each project
66-
# we now have 6 projects in total (3 java, 3 apex)
67-
assert_equal(6, @summary[:configerrors][:removed], 'found removed configerrors')
66+
# we now have 7 projects in total (4 java, 3 apex)
67+
assert_equal(7, @summary[:configerrors][:removed], 'found removed configerrors')
6868

6969
assert_equal("This changeset changes 0 violations,\n" \
7070
"introduces 0 new violations, 0 new errors and 0 new configuration errors,\n" \
71-
'removes 512 violations, 2 errors and 6 configuration errors.',
71+
'removes 512 violations, 2 errors and 7 configuration errors.',
7272
create_summary_message)
7373

7474
assert_file_equals("#{PATCHES_PATH}/expected_patch_config_1.xml", 'target/reports/diff/patch_config.xml')
@@ -101,12 +101,12 @@ def test_case_2_single_xpath_rule_changed
101101
assert_equal(0, @summary[:configerrors][:new], 'found new configerrors')
102102
# Only the rule AvoidMessageDigestField and all other rules from bestpractices have been executed, so the
103103
# configerrors about LoosePackageCoupling are gone, one for each project
104-
# we now have 6 projects in total (3 java, 3 apex)
105-
assert_equal(6, @summary[:configerrors][:removed], 'found removed configerrors')
104+
# we now have 7 projects in total (4 java, 3 apex)
105+
assert_equal(7, @summary[:configerrors][:removed], 'found removed configerrors')
106106

107107
assert_equal("This changeset changes 0 violations,\n" \
108108
"introduces 0 new violations, 0 new errors and 0 new configuration errors,\n" \
109-
'removes 22 violations, 2 errors and 6 configuration errors.',
109+
'removes 22 violations, 2 errors and 7 configuration errors.',
110110
create_summary_message)
111111

112112
assert_file_equals("#{PATCHES_PATH}/expected_patch_config_2.xml", 'target/reports/diff/patch_config.xml')

0 commit comments

Comments
 (0)