chore(ci): Use java 17 as default (#143)

Author: adangel

.github/workflows/build.yml

@@ -27,7 +27,9 @@ jobs:
       - uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 #v4.7.1
         with:
           distribution: 'temurin'
-          java-version: '11'
+          java-version: |
+            11
+            17
       - name: Prepare HOME/openjdk11
         run: ln -sfn "${JAVA_HOME_11_X64}" "${HOME}/openjdk11"
       - uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 #v4.2.4

.github/workflows/manual-integration-tests.yml

@@ -22,7 +22,9 @@ jobs:
       - uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 #v4.7.1
         with:
           distribution: 'temurin'
-          java-version: '11'
+          java-version: |
+            11
+            17
       - name: Prepare HOME/openjdk11
         run: ln -sfn "${JAVA_HOME_11_X64}" "${HOME}/openjdk11"
       - uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 #v4.2.4

History.md

@@ -3,6 +3,7 @@
 ## Enhancements
 ## Fixed Issues
 ## Merged pull requests
+* [#143](https://github.com/pmd/pmd-regression-tester/pull/143): chore(ci): Use java 17 as default - [Andreas Dangel](https://github.com/adangel) (@adangel)
 ## Dependency Updates
 
 # 1.6.1 / 2025-09-19

lib/pmdtester/builders/pmd_report_builder.rb

@@ -250,16 +250,18 @@ def find_pmd_dist_target
 
     def build_pmd_with_maven
       logger.info "#{@pmd_branch_name}: Building PMD #{@pmd_version}..."
+      extra_java_home = nil
 
       package_cmd = if Semver.compare(@pmd_version, '7.14.0') >= 0
                       # build command since PMD migrated to central portal
-                      './mvnw clean package ' \
+                      './mvnw clean package -V ' \
                         '-PfastSkip ' \
                         '-DskipTests ' \
                         '-T1C -B'
                     else
+                      extra_java_home = "#{Dir.home}/openjdk11"
                       # build command for older PMD versions
-                      './mvnw clean package ' \
+                      './mvnw clean package -V ' \
                         "-s #{ResourceLocator.resource('maven-settings.xml')} " \
                         '-Pfor-dokka-maven-plugin ' \
                         '-Dmaven.test.skip=true ' \
@@ -270,8 +272,8 @@ def build_pmd_with_maven
                         '-T1C -B'
                     end
 
-      logger.debug "#{@pmd_branch_name}: maven command: #{package_cmd}"
-      Cmd.execute_successfully(package_cmd)
+      logger.debug "#{@pmd_branch_name}: maven command: #{package_cmd} java_home: #{extra_java_home}"
+      Cmd.execute_successfully(package_cmd, extra_java_home)
     end
   end
 end

lib/pmdtester/cmd.rb

@@ -13,7 +13,7 @@ class Cmd
     # in path.
     #
     def self.execute(cmd, path)
-      stdout, stderr, status = internal_execute(cmd)
+      stdout, stderr, status = internal_execute(cmd, nil)
 
       file = File.new("#{path}/stdout.txt", 'w')
       file.puts stdout
@@ -26,8 +26,8 @@ def self.execute(cmd, path)
       status
     end
 
-    def self.execute_successfully(cmd)
-      stdout, stderr, status = internal_execute(cmd)
+    def self.execute_successfully(cmd, extra_java_home = nil)
+      stdout, stderr, status = internal_execute(cmd, extra_java_home)
 
       unless status.success?
         logger.error "Command failed: #{cmd}"
@@ -40,14 +40,20 @@ def self.execute_successfully(cmd)
     end
 
     def self.stderr_of(cmd)
-      _stdout, stderr, _status = internal_execute(cmd)
+      _stdout, stderr, _status = internal_execute(cmd, nil)
       stderr
     end
 
-    def self.internal_execute(cmd)
-      logger.debug "execute command '#{cmd}'"
+    def self.internal_execute(cmd, extra_java_home)
+      logger.debug "execute command '#{cmd}' (extra_java_home: #{extra_java_home})"
 
-      stdout, stderr, status = Open3.capture3("#{cmd};")
+      new_env = ENV.to_h
+      unless extra_java_home.nil?
+        new_env['JAVA_HOME'] = extra_java_home
+        new_env['PATH'] = "#{extra_java_home}/bin:#{new_env['PATH']}"
+      end
+
+      stdout, stderr, status = Open3.capture3(new_env, "#{cmd};")
 
       logger.debug "status: #{status}"
       logger.debug "stdout: #{stdout}"

test/test_pmd_report_builder.rb

@@ -367,13 +367,14 @@ def cleanup_pmd_dist_dir(base_dir:)
   end
 
   def stub_pmd_build_maven(binary_name:)
-    PmdTester::Cmd.stubs(:execute_successfully).with do |cmd|
-      if cmd == './mvnw clean package ' \
+    PmdTester::Cmd.stubs(:execute_successfully).with do |cmd, extra_java_home|
+      if cmd == './mvnw clean package -V ' \
                 "-s #{PmdTester::ResourceLocator.resource('maven-settings.xml')} " \
                 '-Pfor-dokka-maven-plugin ' \
                 '-Dmaven.test.skip=true ' \
                 '-Dmaven.javadoc.skip=true -Dmaven.source.skip=true ' \
-                '-Dcheckstyle.skip=true -Dpmd.skip=true -T1C -B'
+                '-Dcheckstyle.skip=true -Dpmd.skip=true -T1C -B' &&
+         extra_java_home == "#{Dir.home}/openjdk11"
         FileUtils.mkdir_p 'pmd-dist/target'
         FileUtils.touch "pmd-dist/target/#{binary_name}"
         true
@@ -384,11 +385,12 @@ def stub_pmd_build_maven(binary_name:)
   end
 
   def stub_pmd_build_maven_new_pmd7_build
-    PmdTester::Cmd.stubs(:execute_successfully).with do |cmd|
-      if cmd == './mvnw clean package ' \
+    PmdTester::Cmd.stubs(:execute_successfully).with do |cmd, extra_java_home|
+      if cmd == './mvnw clean package -V ' \
                 '-PfastSkip ' \
                 '-DskipTests ' \
-                '-T1C -B'
+                '-T1C -B' &&
+         extra_java_home.nil?
         FileUtils.mkdir_p 'pmd-dist/target'
         FileUtils.touch "pmd-dist/target/pmd-dist-#{@pmd_version}-bin.zip"
         true