fix for bug #4827 (#5026)

* fix for bug #4943

* fix for bug 4827

* refactor code

---------

Co-authored-by: Gautam Sheth <[email protected]>

Author: reshmee011

src/Commands/Admin/SetHomeSite.cs

@@ -27,55 +27,58 @@ public class SetHomeSite : PnPSharePointOnlineAdminCmdlet
         protected override void ExecuteCmdlet()
         {
             Tenant.EnsureProperties(t => t.IsMultipleVivaConnectionsFlightEnabled, t => t.IsVivaHomeFlightEnabled);
+            HomeSiteConfigurationParam configurationParam;
+
+            bool hasVivaConnectionsDefaultStart = ParameterSpecified(nameof(VivaConnectionsDefaultStart));
+            bool hasDraftMode = ParameterSpecified(nameof(DraftMode));
+
+            // Replace the current configurationParam assignment block with the following:
+
+            configurationParam = null;
+            if (hasVivaConnectionsDefaultStart || hasDraftMode)
+            {
+                configurationParam = new();
+                if (hasVivaConnectionsDefaultStart)
+                {
+                    configurationParam.vivaConnectionsDefaultStart = VivaConnectionsDefaultStart;
+                    configurationParam.IsVivaConnectionsDefaultStartPresent = true;
+                }
+                if (hasDraftMode)
+                {
+                    configurationParam.isInDraftMode = DraftMode;
+                    configurationParam.IsInDraftModePresent = true;
+                }
+            }
 
             if (Tenant.IsMultipleVivaConnectionsFlightEnabled)
             {
                 if (Force || ShouldContinue("Before you update a home site or Viva Connections experiences, make sure you review the documentation at https://aka.ms/homesites.", Properties.Resources.Confirm))
                 {
                     IEnumerable<TargetedSiteDetails> enumerable = Tenant.GetTargetedSitesDetails()?.Where((TargetedSiteDetails hs) => !hs.IsVivaBackendSite);
                     AdminContext.ExecuteQueryRetry();
-                    bool flag = false;
                     if (enumerable == null || enumerable.Count() == 0)
                     {
                         Tenant.AddHomeSite(HomeSiteUrl, 1, null);
                         AdminContext.ExecuteQueryRetry();
-                        flag = true;
                     }
                     else if (enumerable.Count() == 1 && !IsSameSiteUrl(enumerable.First().Url, HomeSiteUrl))
                     {
                         Tenant.RemoveTargetedSite(enumerable.First().SiteId);
                         AdminContext.ExecuteQueryRetry();
                         Tenant.AddHomeSite(HomeSiteUrl, 1, null);
                         AdminContext.ExecuteQueryRetry();
-                        flag = true;
                     }
-                    HomeSiteConfigurationParam configurationParam = new()
-                    {
-                        vivaConnectionsDefaultStart = VivaConnectionsDefaultStart,
-                        IsVivaConnectionsDefaultStartPresent = VivaConnectionsDefaultStart,
-                        isInDraftMode = DraftMode,
-                        IsInDraftModePresent = DraftMode || flag
-                    };
+                    
                     ClientResult<TargetedSiteDetails> clientResult = Tenant.UpdateTargetedSite(HomeSiteUrl, configurationParam);
+
                     AdminContext.ExecuteQueryRetry();
                     WriteObject(clientResult.Value);
                 }
             }
             else if (Force || ShouldContinue("Before you set a Home site, make sure you review the documentation at https://aka.ms/homesites.", Properties.Resources.Confirm))
             {
                 Tenant.ValidateVivaHomeParameterExists(VivaConnectionsDefaultStart);
-                HomeSiteConfigurationParam configuration = null;
-                if (VivaConnectionsDefaultStart || DraftMode)
-                {
-                    configuration = new HomeSiteConfigurationParam
-                    {
-                        vivaConnectionsDefaultStart = VivaConnectionsDefaultStart,
-                        IsVivaConnectionsDefaultStartPresent = VivaConnectionsDefaultStart,
-                        isInDraftMode = DraftMode,
-                        IsInDraftModePresent = DraftMode
-                    };
-                }
-                ClientResult<string> clientResult = Tenant.SetSPHSiteWithConfiguration(HomeSiteUrl, configuration);
+                ClientResult<string> clientResult = Tenant.SetSPHSiteWithConfiguration(HomeSiteUrl, configurationParam);
                 AdminContext.ExecuteQueryRetry();
                 WriteObject(clientResult.Value);
             }