Merge pull request #362 from preactjs/drop-ancestor-binding

Author: marvinhagemeister

src/adapter/10/bindings.ts

@@ -148,18 +148,6 @@ export function findRoot(vnode: VNode, config: RendererConfig): VNode {
 	return vnode;
 }
 
-/**
- * Get the ancestor component that rendered the current vnode
- */
-export function getAncestor(vnode: VNode): VNode | null {
-	let next: VNode | null = vnode;
-	while ((next = getVNodeParent(next)) != null) {
-		return next;
-	}
-
-	return null;
-}
-
 /**
  * Get human readable name of the component/dom element
  */
@@ -287,7 +275,6 @@ export const bindingsV10: PreactBindings<VNode> = {
 	getDisplayName,
 	getPropsVNodeDisplayName: getDisplayName,
 	getActualChildren,
-	getAncestor,
 	getDom,
 	isTextVNode,
 	getInstance,

src/adapter/11/bindings.ts

@@ -257,18 +257,6 @@ export function getHookState(
 	return [];
 }
 
-/**
- * Get the ancestor component that rendered the current vnode
- */
-export function getAncestor(vnode: Internal): Internal | null {
-	let next: Internal | null = vnode;
-	while ((next = getVNodeParent(next)) != null) {
-		return next;
-	}
-
-	return null;
-}
-
 export function createSuspenseState(vnode: Internal, suspended: boolean) {
 	const c = getComponent(vnode) as Component;
 	const key = getSuspenseStateKey(c);
@@ -302,7 +290,6 @@ export const bindingsV11: PreactBindings<Internal> = {
 	getDisplayName,
 	getPropsVNodeDisplayName,
 	getActualChildren,
-	getAncestor,
 	getDom,
 	isTextVNode: isTextInternal,
 	getInstance,

src/adapter/shared/bindings.ts

@@ -11,7 +11,6 @@ export type ComponentHooks = Record<string, any>;
 export type HookState = Record<string, any>;
 
 export interface PreactBindings<T extends SharedVNode = SharedVNode> {
-	getAncestor(vnode: T): T | null;
 	getDisplayName(vnode: T, config: RendererConfig): string;
 	getPropsVNodeDisplayName(vnode: any, config: RendererConfig): string;
 	isRoot(vnode: T, config: RendererConfig): boolean;

src/adapter/shared/traverse.ts

@@ -513,14 +513,14 @@ function findClosestNonFilteredParent<T extends SharedVNode>(
 	vnode: T,
 ) {
 	let parentId = -1;
-	let ancestor: T | null = helpers.getAncestor(vnode);
-	while (ancestor !== null) {
-		parentId = getVNodeId(ids, ancestor);
+	let parent: T | null = helpers.getVNodeParent(vnode);
+	while (parent !== null) {
+		parentId = getVNodeId(ids, parent);
 		if (parentId !== -1) {
 			break;
 		}
 
-		ancestor = helpers.getAncestor(ancestor);
+		parent = helpers.getVNodeParent(parent);
 	}
 
 	return parentId;