Build fail because of TypeScript error

[aymericzip]

Thanks for this awesome tool.

• Check if updating to the latest preact-iso version resolves the issue

Describe the bug
On a vite / preact app, the build fail when the "skipLibCheck": false, is set (or undefined)
Error list

> vite-preact-app-example@0.0.0 build /Users/aymericpineau/Documents/intlayer/examples/vite-preact-app
> tsc -b && vite build

../../node_modules/.pnpm/@preact+preset-vite@2.10.1_@babel+core@7.27.1_preact@10.26.6_vite@6.3.5_@types+node@22._9bdfb6acc424a5d7c97567e6f039ee02/node_modules/@preact/preset-vite/dist/esm/index.d.mts:2:36 - error TS7016: Could not find a declaration file for module '@rollup/pluginutils'. '/Users/aymericpineau/Documents/intlayer/node_modules/.pnpm/@rollup+pluginutils@4.2.1/node_modules/@rollup/pluginutils/dist/es/index.js' implicitly has an 'any' type.
  There are types at '/Users/aymericpineau/Documents/intlayer/node_modules/.pnpm/@preact+preset-vite@2.10.1_@babel+core@7.27.1_preact@10.26.6_vite@6.3.5_@types+node@22._9bdfb6acc424a5d7c97567e6f039ee02/node_modules/@rollup/pluginutils/types/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@rollup/pluginutils' library may need to update its package.json or typings.

2 import type { FilterPattern } from "@rollup/pluginutils";
                                     ~~~~~~~~~~~~~~~~~~~~~

../../node_modules/.pnpm/preact-iso@2.9.1_preact-render-to-string@6.5.13_preact@10.26.6__preact@10.26.6/node_modules/preact-iso/src/router.d.ts:18:2 - error TS2411: Property 'params' of type '{ [param: string]: string; }' is not assignable to 'string' index type 'string'.

18  params: {
    ~~~~~~

../../node_modules/.pnpm/preact-iso@2.9.1_preact-render-to-string@6.5.13_preact@10.26.6__preact@10.26.6/node_modules/preact-iso/src/router.d.ts:21:2 - error TS2411: Property 'rest' of type 'string | undefined' is not assignable to 'string' index type 'string'.

21  rest?: string;
    ~~~~

../../node_modules/.pnpm/preact-iso@2.9.1_preact-render-to-string@6.5.13_preact@10.26.6__preact@10.26.6/node_modules/preact-iso/src/router.d.ts:24:2 - error TS2411: Property 'params' of type '{ [param: string]: string; }' is not assignable to 'string' index type 'string'.

24  params: {
    ~~~~~~

../../node_modules/.pnpm/preact-iso@2.9.1_preact-render-to-string@6.5.13_preact@10.26.6__preact@10.26.6/node_modules/preact-iso/src/router.d.ts:27:2 - error TS2411: Property 'rest' of type 'string | undefined' is not assignable to 'string' index type 'string'.

27  rest?: string;
    ~~~~

../../node_modules/.pnpm/preact-iso@2.9.1_preact-render-to-string@6.5.13_preact@10.26.6__preact@10.26.6/node_modules/preact-iso/src/router.d.ts:63:41 - error TS2312: An interface can only extend an object type or intersection of object types with statically known members.

63   interface IntrinsicAttributes extends RoutableProps {}
                                           ~~~~~~~~~~~~~

../../node_modules/.pnpm/preact-iso@2.9.1_preact-render-to-string@6.5.13_preact@10.26.6__preact@10.26.6/node_modules/preact-iso/src/router.d.ts:65:31 - error TS2312: An interface can only extend an object type or intersection of object types with statically known members.

65  interface Attributes extends RoutableProps {}
                                 ~~~~~~~~~~~~~


Found 7 errors.

{
  "name": "vite-preact-app-example",
  "type": "module",
  "scripts": {
    "build": "tsc -b && vite build",
    "dev": "vite",
    "preview": "vite preview",
    "start:editor": "intlayer-editor start"
  },
  "dependencies": {
    "preact": "^10.26.4",
    "preact-iso": "^2.9.1"
  },
  "devDependencies": {
    "@preact/preset-vite": "^2.10.1",
    "typescript": "~5.7.2",
    "vite": "^6.3.1",
    "vite-intlayer": "workspace:*"
  }
}

Note that skipping the external package type checking make the build pass. The code logic is not impacted

To Reproduce

GitHub demo repo

Steps to reproduce the behavior:

1. install the packages
2. set "skipLibCheck": true in the tsconfig.json file
3. build the app

Expected behavior
Build should pass without "skipLibCheck": true

[rschristian]

#95 should fix some of these, though the RoutableProps error I cannot reproduce and the @rollup/pluginutils definitely is unrelated to this repo.

Generally I don't think we should provide guarantees around skipLibCheck anyhow, it's something users really should have enabled and it improves perf considerably. There's no good reason to be type checking node_modules. It admittedly is a pain if you have .d.ts files in your source, but until the TS team gives us better controls, disabling skipLibCheck temporarily is the best I can suggest there.

[aymericzip]

My bad, installing again using npm instead of pnpm fixed the problem. It's probably a cache issue. Sorry for that.

I will close the issue

[rschristian]

Not a problem, and you did raise valid issues; I always forget that jsconfig.json defaults to enabling skipLibCheck so we did have some errors here that we weren't aware of.

If you can reproduce the RoutableProps error please let me know, it might be valid? Not quite sure how to get that error message to occur though.

[aymericzip]

I tried again and met it again.. sorry again, I will reopen..

I probably just forgot to save my tsconfig during my last try after making the change

You can try using this demo repo, it use the default vite preact-ts template with preact-iso + intlayer installed

1. npm i
2. set "skipLibCheck": true in the tsconfig.json file
3. npm run build

[rschristian]

PRs welcome, but I think you're going to need to enable skipLibCheck, I don't think we can change the way this works. Attributes & IntrinsicAttributes must be interfaces & must extend a dynamic object.

And, FWIW, I'd probably recommend against using Vite's templates, they're not something we control and the TS setup in them is kinda absurd. create-preact will get you setup how we'd recommend.