You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-3Lines changed: 4 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,14 +6,15 @@ First, thank you for considering contributing to react-redux-firebase! It's peop
6
6
7
7
We welcome any type of contribution, not only code. You can help with
8
8
-**QA**: file bug reports, the more details you can give the better (e.g. screenshots with the console open)
9
-
-**Marketing**: writing blog posts, howto's, printing stickers, ...
10
9
-**Community**: presenting the project at meetups, organizing a dedicated meetup for the local community, ...
11
10
-**Code**: take a look at the [open issues](issues). Even if you can't write code, commenting on them, showing that you care about a given issue matters. It helps us triage them.
12
11
-**Money**: we welcome financial contributions as detailed in the [financial contributions section](#financial-contributions).
13
12
14
13
## Your First Contribution
15
14
16
-
Working on your first Pull Request? You can learn how from this *free* series, [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github).
15
+
Working on your first Pull Request? Checkout the [contributing section of the docs](http://react-redux-firebase.com/docs/contributing.html) for hints on contributing to different pieces of the project.
16
+
17
+
Want more general information on contributing to open source projects? Checkout this *free* series, [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github).
17
18
18
19
## Submitting code
19
20
@@ -31,7 +32,7 @@ Financial contributions are welcomed through either [patreon](https://www.patreo
31
32
## Questions
32
33
33
34
If you have any questions, create an [issue](issue) (protip: do a quick search first to see if someone else didn't ask the same question before!).
34
-
You can also reach us at hello@react-redux-firebase.opencollective.com.
35
+
You can also reach us on [gitter](https://gitter.im/redux-firebase/Lobby).
Copy file name to clipboardExpand all lines: docs/contributing.md
+24-6Lines changed: 24 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,13 +1,31 @@
1
1
# Contributing
2
2
3
3
1. Fork to your account
4
-
2. Make changes and push to YOUR fork of the repo (linting is run automatically on push, and tests/coverage are run on [Travis](https://travis-ci.org/prescottprue/react-redux-firebase))
5
-
3. Create a pull request on [react-redux-firebase](https://github.com/prescottprue/react-redux-firebase) with a description of your changes
6
-
4. Confirm that you have no merge conflicts that will keep the code from being merged
7
-
5. Keep an eye on the Pull Request for comments/updates
4
+
1. Make changes and push to YOUR fork of the repo (linting is run automatically on push, and tests/coverage are run on [Travis](https://travis-ci.org/prescottprue/react-redux-firebase))
5
+
1. Test the changes within your project by npm linking your local version of ([described below]())
6
+
1. Create a pull request on [react-redux-firebase](https://github.com/prescottprue/react-redux-firebase) with a description of your changes
7
+
1. Confirm that you have no merge conflicts that will keep the code from being merged
8
+
1. Keep an eye on the Pull Request for comments/updates
8
9
10
+
## Docs
9
11
10
-
## NPM Linking
12
+
All docs are written in Markdown and contained within the `docs` folder.
13
+
14
+
The API reference section of the docs lives within `docs/api` and is generated from JSDoc comments within the `src` when calling `npm run docs:build`.
15
+
16
+
### Updating API Docs
17
+
18
+
1. Go to the source code of the function which is having docs updated
19
+
1. Change associated section of the comment above the function (i.e `@example` or `@description`)
20
+
1. Run `npm run build:docs`
21
+
1. Remove any `gitbook-` dependencies added to `package.json` during the process (due to but in gitbook-cli, see note below)
22
+
1. Create a PR with from your fork to the `master` branch of this repo
23
+
24
+
**NOTE**: Currently, during the build stage, gitbook adds gitbook dependencies to the `dependencies` section of `package.json`. This is not desired behavior - if you are making a PR with changes to the docs, make sure you have removed any `gitbook-*` dependencies from the package.json that may have been added while building docs
25
+
26
+
## Library Source
27
+
28
+
### NPM Linking
11
29
12
30
It is often convenient to run a local version of `react-redux-firebase` within a project to debug issues. The can be accomplished by doing the following:
13
31
@@ -22,7 +40,7 @@ It is often convenient to run a local version of `react-redux-firebase` within a
22
40
**NOTE**
23
41
`npm run watch` can be used in your local `react-redux-firebase` folder to run a watch server that will rebuild as you make changes. Only the `commonjs` version is rebuild when using `npm run watch`. If using a different version, such as the `es` version, add watch flag to specific npm build command (i.e. `npm run build:es -- --watch`) to only rebuild that version when files are changed.
0 commit comments