Skip to content

Commit ace0ea4

Browse files
corylowntaylor-steve
authored andcommitted
Merge pull request #3247 from projectblacklight/drop-blacklight7
Remove active support for Blacklight 7
2 parents db7e3b3 + c39b453 commit ace0ea4

File tree

6 files changed

+7
-17
lines changed

6 files changed

+7
-17
lines changed

.github/workflows/ruby.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,20 @@ jobs:
1414
rails_version: ["~> 7.2"]
1515
ruby: ["3.2", "3.3"]
1616
bootstrap_version: ["~> 4.0"]
17-
blacklight_version: ["~> 7.34"]
17+
blacklight_version: ["~> 8.0"]
1818
additional_engine_cart_rails_options: ["-a propshaft -j esbuild"]
1919
additional_name: [""]
2020
include:
2121
- rails_version: "~> 7.2"
2222
ruby: "3.3"
23-
blacklight_version: "~> 7.38"
23+
blacklight_version: "~> 8.0"
2424
bootstrap_version: "~> 5.0"
2525
additional_name: Bootstrap 5
2626
- rails_version: "7.1.4"
2727
ruby: "3.2"
28-
blacklight_version: "~> 7.38"
29-
bootstrap_version: "~> 4.0"
30-
additional_name: Rails 7.1
31-
- rails_version: "~> 7.2"
32-
ruby: "3.3"
3328
blacklight_version: "~> 8.0"
3429
bootstrap_version: "~> 4.0"
35-
additional_name: Blacklight 8
30+
additional_name: Rails 7.1
3631
env:
3732
RAILS_VERSION: ${{ matrix.rails_version }}
3833
BLACKLIGHT_VERSION: ${{ matrix.blacklight_version }}

blacklight-spotlight.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ these collections.)
2222

2323
s.add_dependency 'activejob-status'
2424
s.add_dependency 'acts-as-taggable-on', '>= 5.0', '< 12'
25-
s.add_dependency 'blacklight', '>= 7.38', '< 9'
25+
s.add_dependency 'blacklight', '~> 8.0'
2626
s.add_dependency 'blacklight-gallery', '>= 3.0', '< 5'
2727
s.add_dependency 'bootstrap_form', '>= 4.1', '< 6'
2828
s.add_dependency 'cancancan'

lib/generators/spotlight/assets/propshaft_generator.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,6 @@ def add_javascript
7474
gsub_file 'app/javascript/application.js', 'import "controllers"', '// import "controllers"'
7575

7676
append_to_file 'app/javascript/application.js', "\n// Bootstrap\nimport * as Bootstrap from 'bootstrap'\n"
77-
78-
if Blacklight::VERSION.start_with?('7')
79-
append_to_file 'app/javascript/application.js', "\n// Blacklight\nimport \"blacklight-frontend/app/assets/javascripts/blacklight/blacklight.js\"\n"
80-
end
81-
8277
append_to_file 'app/javascript/application.js', "\n// Spotlight\nimport Spotlight from \"spotlight-frontend\"\n"
8378
end
8479

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"not IE 11"
3333
],
3434
"dependencies": {
35-
"blacklight-frontend": ">= 7.38 < 9",
35+
"blacklight-frontend": "^8.4.0",
3636
"bootstrap": ">=4.3.1 <6.0.0",
3737
"clipboard": "^2.0.11",
3838
"jquery": "^3.7.1",

spec/test_app_templates/lib/generators/test_app_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def use_capybara3
1010
end
1111

1212
def add_gems
13-
gem 'blacklight', ENV['BLACKLIGHT_VERSION'] || '~> 7.38' unless Bundler.locked_gems.dependencies.key? 'blacklight'
13+
gem 'blacklight', ENV['BLACKLIGHT_VERSION'] || '~> 8.0' unless Bundler.locked_gems.dependencies.key? 'blacklight'
1414
gem 'blacklight-gallery', '~> 4.5' unless Bundler.locked_gems.dependencies.key? 'blacklight-gallery'
1515
gem 'cssbundling-rails' unless defined?(Sprockets)
1616

template.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
bootstrap_version = ENV.fetch('BOOTSTRAP_VERSION', '~> 5.3')
1010

1111
# Add gem dependencies to the application
12-
gem 'blacklight', ' ~> 7.38'
12+
gem 'blacklight', '~> 8.0'
1313
gem 'blacklight-spotlight', ENV['SPOTLIGHT_GEM'] ? { path: ENV['SPOTLIGHT_GEM'] } : { github: 'projectblacklight/spotlight' }
1414
gem 'sidekiq'
1515
gem 'bootstrap_form', /(\d)(?:\.\d){0,2}/.match(bootstrap_version)[1].to_i == 5 ? '~> 5.4' : '~> 4.5'

0 commit comments

Comments
 (0)