Merge pull request #1469 from psu-libraries/niftany-upgrade

Niftany upgrade

Author: granta03

.circleci/config.yml

@@ -92,7 +92,8 @@ jobs:
         name: "Update Node.js and npm"
         command: |
           curl -sSL "https://nodejs.org/dist/v22.14.0/node-v22.14.0-linux-x64.tar.xz" | sudo tar --strip-components=2 -xJ -C /usr/local/bin/ node-v22.14.0-linux-x64/bin/node
-          curl -L https://npmjs.com/install.sh | sudo bash
+          sudo corepack enable
+          sudo corepack prepare [email protected] --activate
     - run:
         name: "Bundle"
         command: |

.rubocop.yml

@@ -15,6 +15,9 @@ AllCops:
     - 'vendor/**/*'
   NewCops: enable
 
+Capybara/NegationMatcherAfterVisit:
+  Enabled: false
+
 Metrics/BlockLength:
   Exclude:
   # The catalog controller is just one giant block for config.
@@ -66,13 +69,10 @@ RSpec/ExampleLength:
   # Feature specs are special.
   - 'spec/features/**/*'
 
-RSpec/NestedGroups:
-  Enabled: false
-
-RSpec/Capybara/FeatureMethods:
+RSpec/IndexedLet:
   Enabled: false
 
-RSpec/Capybara:
+RSpec/NestedGroups:
   Enabled: false
 
 RSpec/MultipleMemoizedHelpers:

.rubocop_todo.yml

@@ -35,18 +35,6 @@ Performance/CollectionLiteralInLoop:
   Exclude:
     - 'config/environments/production.rb'
 
-# Offense count: 25
-RSpec/Capybara:
-  Exclude:
-    - 'spec/components/psul_constraint_layout_component_spec.rb'
-    - 'spec/features/ask_a_librarian_spec.rb'
-    - 'spec/features/availability_spec.rb'
-    - 'spec/features/google_preview_link_spec.rb'
-    - 'spec/views/browse/authors.html.erb_spec.rb'
-    - 'spec/views/browse/call_numbers.html.erb_spec.rb'
-    - 'spec/views/browse/subjects.html.erb_spec.rb'
-    - 'spec/views/browse/titles.html.erb_spec.rb'
-
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/ExpectActual:
@@ -70,3 +58,7 @@ Rails/I18nLocaleTexts:
 Style/OptionalBooleanParameter:
   Exclude:
     - 'app/helpers/facets_helper.rb'
+
+Lint/UselessConstantScoping:
+  Exclude:
+    - app/components/psul_facet_item_component.rb

Gemfile

@@ -51,8 +51,9 @@ end
 group :development, :test do
   gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
   gem 'html_tokenizer', '~> 0.0.8'
-  gem 'niftany', '~> 0.10'
+  gem 'niftany', '~> 0.12.1'
   gem 'pry-byebug'
+  gem 'rubocop-capybara'
   gem 'sinatra'
   gem 'sqlite3', '~> 1.5.0'
 end