-
Notifications
You must be signed in to change notification settings - Fork 20
Faisal/svm #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Faisal/svm #7
Conversation
micprog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is still work in progress, so I converted to draft. Feel free to mark as ready for review when ready.
| svm_trans trans; | ||
| mailbox svm_trans gen2drvr_mbx; | ||
|
|
||
| virtual functiona svm_trans gen (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| virtual functiona svm_trans gen (); | |
| virtual function svm_trans gen (); |
| //some useful typedefs | ||
| // | ||
| // | ||
| package svm_pkg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, what does SVM stand for?
| //TODO: connect gen2drvr _mbx to generators' gen2drvr_mbx; | ||
| //TODO: replace durif in virtual interface declaration with appropriate | ||
| //interface name | ||
| //TODO:fill in the drive task | ||
| //TODO:define a constructor which should: | ||
| //a) create the mailbox | ||
| //b) provide a name for the driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are still a lot of todos
|
Thanks for reviewing it
These base classes are meant as templates over which to build the testbench.
The TODOs are notes to the testbench builder for step they have to do to complete the testbench implementation
SVM stands for systemverilog methodology
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Michael Rogenmoser ***@***.***>
Sent: Saturday, May 18, 2024 4:01:09 AM
To: pulp-platform/common_verification ***@***.***>
Cc: Faisal Haque ***@***.***>; Author ***@***.***>
Subject: Re: [pulp-platform/common_verification] Faisal/svm (PR #7)
@micprog commented on this pull request.
It looks like this is still work in progress, so I converted to draft. Feel free to mark as ready for review when ready.
________________________________
In svm/svm_pkg.svh<#7 (comment)>:
+ virtual task run();
+ virtual task finish();
+ endclass
+ virtual class svm_trans;
+ string name;
+ svm_logger log;
+
+ virtual function svm_trans cp();
+ virtual task pr();
+ virtual function bit compare(svm_trans trans);
+ endclass
+ virtual class svm_generator extends svm_component;
+ svm_trans trans;
+ mailbox svm_trans gen2drvr_mbx;
+
+ virtual functiona svm_trans gen ();
⬇️ Suggested change
- virtual functiona svm_trans gen ();
+ virtual function svm_trans gen ();
________________________________
In svm/svm_pkg.svh<#7 (comment)>:
@@ -0,0 +1,126 @@
+//SVM Base class lib:
+//svm_component
+//svm_trans
+//svm_logger
+//macros if any
+//svm_generator
+//svm_env
+//svm_driver
+//svm_monitor
+//svm_scoreboard
+//svm_test
+//some useful typedefs
+//
+//
+package svm_pkg;
Just out of curiosity, what does SVM stand for?
________________________________
In svm/svm_pkg.svh<#7 (comment)>:
+ //TODO: connect gen2drvr _mbx to generators' gen2drvr_mbx;
+ //TODO: replace durif in virtual interface declaration with appropriate
+ //interface name
+ //TODO:fill in the drive task
+ //TODO:define a constructor which should:
+ //a) create the mailbox
+ //b) provide a name for the driver
It looks like there are still a lot of todos
—
Reply to this email directly, view it on GitHub<#7 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BIPB3SRI4IGFAPASEW2AXK3ZC4YHLAVCNFSM6AAAAABH4TJRYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRUG4ZDIMBZHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This imports the sum_pkg.svh which is a base class library we will use to create test benches
The code is uncompiled so wee will need to compile and fix any compile issues