Make "data" argument required in ModelChain.run_model_from_effective_irradiance (#1720)

* Made "data" argument in the mc.run_model_from_effective_irradiance as a required argument.

* Maded "data" argument required for subfunction
_prepare_temperature and _run_from_effective_irrad

* Removed "default None" from docstring

* Added bug fix comment in v0.9.6 and contributors name.

Author: k10blogger

docs/sphinx/source/whatsnew/v0.9.6.rst

@@ -15,7 +15,8 @@ Enhancements
 
 Bug fixes
 ~~~~~~~~~
-
+* `data` can no longer be left unspecified in
+  :py:meth:`pvlib.modelchain.ModelChain.run_model_from_effective_irradiance`. (:issue:`1713`, :pull:`1720`)
 
 Testing
 ~~~~~~~
@@ -37,3 +38,4 @@ Requirements
 Contributors
 ~~~~~~~~~~~~
 * Adam R. Jensen (:ghuser:`adamrjensen`)
+* Siddharth Kaul (:ghuser:`k10blogger`)

pvlib/modelchain.py

@@ -1686,7 +1686,7 @@ def _prepare_temperature_single_array(self, data, poa):
             self.temperature_model()
         return self
 
-    def _prepare_temperature(self, data=None):
+    def _prepare_temperature(self, data):
         """
         Sets cell_temperature using inputs in data and the specified
         temperature model.
@@ -1699,7 +1699,7 @@ def _prepare_temperature(self, data=None):
 
         Parameters
         ----------
-        data : DataFrame, default None
+        data : DataFrame
             May contain columns ``'cell_temperature'`` or
             ``'module_temperaure'``.
 
@@ -1878,13 +1878,13 @@ def run_model_from_poa(self, data):
 
         return self
 
-    def _run_from_effective_irrad(self, data=None):
+    def _run_from_effective_irrad(self, data):
         """
         Executes the temperature, DC, losses and AC models.
 
         Parameters
         ----------
-        data : DataFrame, or tuple of DataFrame, default None
+        data : DataFrame, or tuple of DataFrame
             If optional column ``'cell_temperature'`` is provided, these values
             are used instead of `temperature_model`. If optional column
             `module_temperature` is provided, `temperature_model` must be
@@ -1907,7 +1907,7 @@ def _run_from_effective_irrad(self, data=None):
 
         return self
 
-    def run_model_from_effective_irradiance(self, data=None):
+    def run_model_from_effective_irradiance(self, data):
         """
         Run the model starting with effective irradiance in the plane of array.