Bugfix/atmos refract typo (#2592)

* Prevent atmos_refract docstring typo regression

Add tests to ensure parameter name is documented as 'atmos_refract'
(not 'atmos_refrac') in spa_python and solar_position docstrings.

Related to #2532

* Fix atmos_refract parameter name typo in docstrings

Correct parameter name from 'atmos_refrac' to 'atmos_refract' in
docstrings for solarposition.spa_python and spa.solar_position to
match the actual function signatures.

Update whatsnew to describe this change.

Closes #2532

* Break long lines up in test files

* Revert "Break long lines up in test files"

This reverts commit 452876d.

* Revert "Prevent atmos_refract docstring typo regression"

This reverts commit 216db9e.

* Add PR number and contributer name to whatsnew

Author: josephradford

docs/sphinx/source/whatsnew/v0.13.2.rst

@@ -47,6 +47,8 @@ Enhancements
 Documentation
 ~~~~~~~~~~~~~
 * Provide an overview of single-diode modeling functionality in :ref:`singlediode`. (:pull:`2565`)
+* Fix typo in parameter name ``atmos_refract`` in :py:func:`pvlib.solarposition.spa_python`
+  and :py:func:`pvlib.spa.solar_position`. (:issue:`2532`, :pull:`2592`)
 
 
 Testing
@@ -69,3 +71,4 @@ Contributors
 ~~~~~~~~~~~~
 * Will Hobbs (:ghuser:`williamhobbs`)
 * Cliff Hansen (:ghuser:`cwhanse`)
+* Joseph Radford (:ghuser:`josephradford`)

pvlib/solarposition.py

@@ -314,7 +314,7 @@ def spa_python(time, latitude, longitude,
         using time.year and time.month from pandas.DatetimeIndex.
         For most simulations the default delta_t is sufficient.
         The USNO has historical and forecasted delta_t [3]_.
-    atmos_refrac : float, optional
+    atmos_refract : float, optional
         The approximate atmospheric refraction (in degrees)
         at sunrise and sunset.
     how : str, optional, default 'numpy'

pvlib/spa.py

@@ -1057,7 +1057,7 @@ def solar_position(unixtime, lat, lon, elev, pressure, temp, delta_t,
         degrees C; used for atmospheric correction
     delta_t : float or array
         Difference between terrestrial time and UT1.
-    atmos_refrac : float
+    atmos_refract : float
         The approximate atmospheric refraction (in degrees)
         at sunrise and sunset.
     numthreads: int, optional, default 8