now without unbounded recursion

Author: morrison12

src/pyinfra/api/host.py

@@ -313,7 +313,7 @@ def deploy(
         )
 
     @memoize
-    def get_temp_directory(self):
+    def _get_temp_directory(self):
         temp_directory = self.state.config.TEMP_DIR
 
         if temp_directory is None:
@@ -328,6 +328,10 @@ def get_temp_directory(self):
 
         return temp_directory
 
+    def get_temp_dir_config(self):
+
+        return self.state.config.TEMP_DIR or self.state.config.DEFAULT_TEMP_DIR
+
     def get_temp_filename(
         self,
         hash_key: Optional[str] = None,
@@ -339,7 +343,7 @@ def get_temp_filename(
         Generate a temporary filename for this deploy.
         """
 
-        temp_directory = temp_directory or self.get_temp_directory()
+        temp_directory = temp_directory or self._get_temp_directory()
 
         if not hash_key:
             hash_key = str(uuid4())

src/pyinfra/connectors/util.py

@@ -265,7 +265,7 @@ def _ensure_sudo_askpass_set_for_host(host: "Host"):
     if host.connector_data.get("sudo_askpass_path"):
         return
     _, output = host.run_shell_command(
-        SUDO_ASKPASS_COMMAND.format(host.get_temp_directory(), SUDO_ASKPASS_ENV_VAR)
+        SUDO_ASKPASS_COMMAND.format(host.get_temp_dir_config(), SUDO_ASKPASS_ENV_VAR)
     )
     host.connector_data["sudo_askpass_path"] = shlex.quote(output.stdout_lines[0])
 

src/pyinfra/operations/files.py

@@ -1803,7 +1803,7 @@ def block(
     current = host.get_fact(Block, path=path, marker=marker, begin=begin, end=end)
     cmd = None
 
-    tmp_dir = host.get_temp_directory()
+    tmp_dir = host.get_temp_dir_config()
 
     # standard awk doesn't have an "in-place edit" option so we write to a tempfile and
     # if edits were successful move to dest i.e. we do: <out_prep> ... do some work ... <real_out>

tests/util.py

@@ -198,7 +198,7 @@ def get_file(
     ):
         return True
 
-    def get_temp_directory(*args, **kwargs):
+    def get_temp_dir_config(*args, **kwargs):
         return "_tempdir_"
 
     @staticmethod