Handle the case where the number is just 3600 better

Author: Pierre-Sassoulas

pylint/checkers/format.py

@@ -112,15 +112,11 @@ def to_standard_scientific_notation(cls, number: float) -> str:
 
     @classmethod
     def to_understandable_time(cls, number: float) -> str:
-        if number == 0.0 or number % 3600 != 0:
+        if number == 0.0 or number % 3600 != 0 or number // 3600 == 1:
             return ""  # Not a suspected time
         parts: list[int] = [3600]
         number //= 3600
-        for divisor in (
-            24,
-            7,
-            365,
-        ):
+        for divisor in (24, 7, 365):
             if number % divisor == 0:
                 parts.append(divisor)
                 number //= divisor

tests/checkers/unittest_format.py

@@ -245,3 +245,20 @@ def test_to_another_standard_notation(
     assert (
         time == ""
     ), f"Time notation mismatch expected {expected_underscore}, got {time}"
+
+
+@pytest.mark.parametrize(
+    "value,expected",
+    [
+        (3600, ""),
+        (86400, "3600 * 24"),
+        (604800, "3600 * 24 * 7"),
+        (2592000, "3600 * 24 * 30"),
+        (31536000, "3600 * 24 * 365"),
+        (1180800, "3600 * 24 * 14 - (8 * 3600)"),
+        (315360000, "3600 * 24 * 365 * 10"),
+    ],
+)
+def test_to_understandable_time(value: int, expected: str) -> None:
+    actual = FloatFormatterHelper.to_understandable_time(value)
+    assert actual == expected, f"Expected {expected} for {value}, got {actual}"