We should wait until we can test 3.14 in CI before merging this.

I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests.

Great !

We should wait until we can test 3.14 in CI before merging this.

Agree, so it's Blocked by pylint-dev/astroid#2731 and then the pylint equivalent.

I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests.

Maybe time to design something to be able to expect something different according to the version ?
filename.py

something = 1 # [unused-variable|>=3.13,missing-module-docstring]

With filename.3.14.txt for the expected output of 3.14, filename.txt for the default expected output if the interpreter does not have its specific output file...

I also don't really like that we need to duplicate a lot of tests. Maybe we can come up with a better solution for dealing conditional errors in our tests.

Maybe time to design something to be able to expect something different according to the version ? filename.py

something = 1 # [unused-variable|>=3.13,missing-module-docstring]

With filename.3.14.txt for the expected output of 3.14, filename.txt for the default expected output if the interpreter does not have its specific output file...

Explored something like this in #10382. The diff here would look much better, see 379ab07.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.86%. Comparing base (fccbf98) to head (e359cb9).
⚠️ Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main   #10381   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         176      176           
  Lines       19155    19165   +10     
=======================================
+ Hits        18363    18373   +10     
  Misses        792      792           

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit e359cb9

This PR would is ready now. Even without 3.14 in CI yet, this could be helpful to move #10467 forward. Tested the functional tests locally with 3.14.0rc1. The remaining issues are unrelated to the changes here.