Skip to content

feat: i18n plugin - #16

Merged
ybw0014 merged 1 commit into
pylonmc:mainfrom
ybw0014:feat/i18n
Oct 12, 2025
Merged

ybw0014 merged 1 commit into
pylonmc:mainfrom
ybw0014:feat/i18n

Conversation

@ybw0014

@ybw0014 ybw0014 commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

This PR sets up the i18n plugin and the required folder structure. Basically, moved every file under /docs to /docs/en.

This PR is based on #15, so will be in draft status until that PR is merged.

@Seggan
Seggan requested a review from LordIdra October 9, 2025 18:17

@OhmV-IR OhmV-IR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine structure wise, but missing a language switcher on the actual site. not sure if that's a blocker though, just getting the structure down is probably enough considering we don't offer translations in any other languages atp

@ybw0014

ybw0014 commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

looks fine structure wise, but missing a language switcher on the actual site. not sure if that's a blocker though, just getting the structure down is probably enough considering we don't offer translations in any other languages atp

I added Chinese earlier, and the language switcher showed up correctly. Guess it doesn't show when only 1 language is offered.

@OhmV-IR OhmV-IR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alr will take your word on that and lgtm then

@ybw0014

ybw0014 commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator Author

@LordIdra
LordIdra marked this pull request as ready for review October 11, 2025 20:03

@LordIdra LordIdra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when CI fixed

@ybw0014
ybw0014 merged commit 1ed5335 into pylonmc:main Oct 12, 2025
@ybw0014
ybw0014 deleted the feat/i18n branch October 12, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants