test_simple: fix accidentally skipped test #16777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pypi#15716 (review) Signed-off-by: William Woodruff <[email protected]>
di
approved these changes
Sep 23, 2024
We don't currently report on coverage of the Apply this diff and run diff --git a/pyproject.toml b/pyproject.toml
index e44f6a68e..c07d3cbaf 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,7 +1,7 @@
[tool.coverage.run]
branch = true
dynamic_context = "test_function"
-source = ["warehouse"]
+source = ["warehouse", "tests"]
omit = [
# We don't want to get coverage information for our migrations.
"warehouse/migrations/*",It's probably worth trying to burn down those instances, so we can apply this diff and ensure that every line of code in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
_update_contextbelowtest_with_files_quarantined_omitted_from_indexand into a proper indentation, unskippingtest_with_files_quarantined_omitted_from_indexin the progress. I'm a little surprisedtest_with_files_quarantined_omitted_from_index's skippage wasn't caught by any dead code/unreachability checks 🤔To get
test_with_files_quarantined_omitted_from_indexpassing, I cargo-culted changed based on the other test changes made in #15716.CC @ewdurbin @cofiem
See #15716 (review)