Skip to content

Conversation

@jGaboardi
Copy link
Member

This PR gets us a good chunk of the way to clean esda docs.

A couple outstanding items:

  1. Need the 3 pngs that are missing
  2. Seeing the warning below and having trouble debugging.
    •  python3.13/site-packages/nbconvert/filters/latex.py:57: RemovedInSphinx90Warning: 
          Sphinx 9 will drop support for representing paths as strings.
          Use "pathlib.Path" or "os.fspath" instead.
          text = "".join(LATEX_SUBS.get(c, c) for c in text)
      
  • Did some digging and tried this solution
  • But got even more mysterious:
Click to expand
Versions
========

* Platform:         darwin; (macOS-26.0.1-arm64-arm-64bit-Mach-O)
* Python version:   3.13.7 (CPython)
* Sphinx version:   8.2.3
* Docutils version: 0.21.2
* Jinja2 version:   3.1.6
* Pygments version: 2.19.2

Last Messages
=============

None.

Loaded Extensions
=================

None.

Traceback
=========

    Traceback (most recent call last):
      File "~python3.13/site-packages/sphinx/cmd/build.py", line 414, in build_main
        app = Sphinx(
            srcdir=args.sourcedir,
        ...<14 lines>...
            exception_on_warning=args.exception_on_warning,
        )
      File "~python3.13/site-packages/sphinx/application.py", line 291, in __init__
        self.setup_extension(extension)
        ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
      File "~python3.13/site-packages/sphinx/application.py", line 489, in setup_extension
        self.registry.load_extension(self, extname)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
      File "~python3.13/site-packages/sphinx/registry.py", line 541, in load_extension
        mod = import_module(extname)
      File "~python3.13/importlib/__init__.py", line 88, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
               ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
      File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
      File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 1026, in exec_module
      File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
      File "~python3.13/site-packages/nbsphinx/__init__.py", line 23, in <module>
        import nbconvert
      File "~python3.13/site-packages/nbconvert/__init__.py", line 6, in <module>
        from . import filters, postprocessors, preprocessors, writers
      File "~python3.13/site-packages/nbconvert/filters/__init__.py", line 8, in <module>
        from .markdown import (
        ...<6 lines>...
        )
      File "~python3.13/site-packages/nbconvert/filters/markdown.py", line 16, in <module>
        from .markdown_mistune import markdown2html_mistune
      File "~python3.13/site-packages/nbconvert/filters/markdown_mistune.py", line 21, in <module>
        from nbconvert.filters.strings import add_anchor
      File "~python3.13/site-packages/nbconvert/filters/strings.py", line 23, in <module>
        from nbconvert.preprocessors.sanitize import _get_default_css_sanitizer
      File "~python3.13/site-packages/nbconvert/preprocessors/__init__.py", line 3, in <module>
        from nbclient.exceptions import CellExecutionError
      File "~python3.13/site-packages/nbclient/__init__.py", line 2, in <module>
        from .client import NotebookClient, execute
      File "~python3.13/site-packages/nbclient/client.py", line 17, in <module>
        from jupyter_client.client import KernelClient
      File "~python3.13/site-packages/jupyter_client/__init__.py", line 3, in <module>
        from .asynchronous import AsyncKernelClient
      File "~python3.13/site-packages/jupyter_client/asynchronous/__init__.py", line 1, in <module>
        from .client import AsyncKernelClient  # noqa
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "~python3.13/site-packages/jupyter_client/asynchronous/client.py", line 12, in <module>
        from ..client import KernelClient, reqrep
      File "~python3.13/site-packages/jupyter_client/client.py", line 20, in <module>
        from .connect import ConnectionFileMixin
      File "~python3.13/site-packages/jupyter_client/connect.py", line 22, in <module>
        from jupyter_core.paths import jupyter_data_dir, jupyter_runtime_dir, secure_write
      File "~python3.13/site-packages/jupyter_core/paths.py", line 230, in <module>
        deprecation(
        ~~~~~~~~~~~^
            "Jupyter is migrating its paths to use standard platformdirs\n"
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        ...<3 lines>...
            "The use of platformdirs will be the default in `jupyter_core` v6"
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        )
        ^
      File "~python3.13/site-packages/jupyter_core/utils/__init__.py", line 91, in deprecation
        warnings.warn(message, DeprecationWarning, stacklevel=stacklevel + 1)
        ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
    given by the platformdirs library.  To remove this warning and
    see the appropriate new directories, set the environment variable
    `JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
    The use of platformdirs will be the default in `jupyter_core` v6
  • tried that solution and led to nothing

@jGaboardi jGaboardi self-assigned this Oct 9, 2025
@jGaboardi jGaboardi added the docs label Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.7%. Comparing base (cb1f0d7) to head (1d4727d).

Files with missing lines Patch % Lines
esda/moran.py 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #394   +/-   ##
=====================================
  Coverage   82.7%   82.7%           
=====================================
  Files         27      27           
  Lines       3825    3825           
=====================================
  Hits        3162    3162           
  Misses       663     663           
Files with missing lines Coverage Δ
esda/silhouettes.py 58.7% <ø> (ø)
esda/moran.py 84.9% <75.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ljwolf
Copy link
Member

ljwolf commented Oct 10, 2025

I've sent you the missing files and some link redirections upstream, @jGaboardi, so if you merge that to your fork this will update.

missing files and link changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants