Skip to content

Commit 1293c60

Browse files
committed
Explicitly specify --no-build-isolation as that's our expectation in these tests
Previously we relied on pip to build the packages in non-PEP517 mode, which implied no build isolation. The latest `virtualenv` (with pypa/virtualenv#2868) won't include `wheel` in the virtualenv, which will mean that pip uses PEP-517 mode, which is isolated by default.
1 parent ae8df6d commit 1293c60

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

testing/cffi0/test_zintegration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def remove(dir):
9797
# there's a setuptools/easy_install bug that causes this to fail when the build/install occur together and
9898
# we're in the same directory with the build (it tries to look up dependencies for itself on PyPI);
9999
# subsequent runs will succeed because this test doesn't properly clean up the build- use pip for now.
100-
subprocess.check_call((vp, '-m', 'pip', 'install', '.'), env=env)
100+
subprocess.check_call((vp, '-m', 'pip', 'install', '.', '--no-build-isolation'), env=env)
101101
subprocess.check_call((vp, str(python_f)), env=env)
102102
finally:
103103
os.chdir(olddir)

0 commit comments

Comments
 (0)