gh-135621: Remove dependency on curses from PyREPL #136758
Conversation
|
!buildbot |
ambv
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ambv for commit 58d3e84 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @ambv for commit 0448edd 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
!buildbot aarch64 Android |
|
🤖 New build scheduled with the buildbot fleet by @ambv for commit 0448edd 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
| names = data[offset : offset + name_size - 1].decode( | ||
| "ascii", errors="ignore" | ||
| ) | ||
| offset += name_size |
There was a problem hiding this comment.
AFAIK the name is nul-terminated; should we verify that?
There was a problem hiding this comment.
It doesn't look like this is the case. I tried both data[offset+name_size-1] and data[offset+name_size] but neither are b\x00.
| The ncurses version implements a full stack-based interpreter for | ||
| terminfo parameter strings. This pure Python version implements only | ||
| the subset of parameter substitution operations needed by PyREPL: | ||
| - %i (increment parameters for 1-based indexing) | ||
| - %p[1-9]%d (parameter substitution) | ||
| - %p[1-9]%{n}%+%d (parameter plus constant) |
ambv
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ambv for commit 2a053c5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136758%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Uh oh!
There was an error while loading. Please reload this page.