Skip to content

Conversation

@brianschubert
Copy link
Member

Refs #19329

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for working on this!

Modify the AST directly feels a little strange to me. I wonder if it's worth just adding a mypy AST node and handling it in checkexpr, like we do for say DictExpr?

@brianschubert
Copy link
Member Author

Thanks for taking a look! Yeah, I was hoping to find a less hacky approach. I like the sound of your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants