Pass cast rank to python actor #747
Closed
+147
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79530146 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 4, 2025
Summary: Rollback Plan: Differential Revision: D79530146
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 4, 2025
Summary: Rollback Plan: Differential Revision: D79530146
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 4, 2025
Summary: Rollback Plan: Differential Revision: D79530146
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 4, 2025
Summary: Rollback Plan: Differential Revision: D79530146
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 5, 2025
Summary: Rollback Plan: Differential Revision: D79530146
pzhan9
force-pushed
the
export-D79530146
branch
from
1efcff1 to
919f69d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79530146 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 5, 2025
Summary: Rollback Plan: Differential Revision: D79530146
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 6, 2025
Summary: When casting to a sliced mesh, the actors rank on the sliced mesh is different from the rank on the root mesh. Currently, the root mesh's rank is passed to Python actor. [That is wrong](https://www.internalfb.com/diff/D78355743?dst_version_fbid=1460199675405905&transaction_fbid=1279216557057466). We need to pass the rank on the cast mesh. If the cast mesh is a sliced mesh, then it should be sliced mesh rank. This diff fixes this. Reviewed By: mariusae Differential Revision: D79530146
pzhan9
force-pushed
the
export-D79530146
branch
from
919f69d to
304a5f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79530146 |
Summary: When casting to a sliced mesh, the actors rank on the sliced mesh is different from the rank on the root mesh. Currently, the root mesh's rank is passed to Python actor. [That is wrong](https://www.internalfb.com/diff/D78355743?dst_version_fbid=1460199675405905&transaction_fbid=1279216557057466). We need to pass the rank on the cast mesh. If the cast mesh is a sliced mesh, then it should be sliced mesh rank. This diff fixes this. Reviewed By: mariusae Differential Revision: D79530146
pzhan9
force-pushed
the
export-D79530146
branch
from
304a5f3 to
caa2fa4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79530146 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Aug 6, 2025
Summary: When casting to a sliced mesh, the actors rank on the sliced mesh is different from the rank on the root mesh. Currently, the root mesh's rank is passed to Python actor. [That is wrong](https://www.internalfb.com/diff/D78355743?dst_version_fbid=1460199675405905&transaction_fbid=1279216557057466). We need to pass the rank on the cast mesh. If the cast mesh is a sliced mesh, then it should be sliced mesh rank. This diff fixes this. Reviewed By: mariusae Differential Revision: D79530146
|
This pull request has been merged in 7d767cf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D79530146