Skip to content

Create hyperactor_mesh config file #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions hyperactor/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ pub mod global {
static MUTEX: LazyLock<std::sync::Mutex<()>> = LazyLock::new(|| std::sync::Mutex::new(()));
ConfigLock {
_guard: MUTEX.lock().unwrap(),
config: CONFIG.clone(),
}
}

/// Create a new ConfigLock with a specific config.
pub fn new(config: Arc<RwLock<Attrs>>) -> ConfigLock {
static MUTEX: LazyLock<std::sync::Mutex<()>> = LazyLock::new(|| std::sync::Mutex::new(()));
ConfigLock {
_guard: MUTEX.lock().unwrap(),
config,
}
}

Expand Down Expand Up @@ -222,6 +232,7 @@ pub mod global {
/// this ConfigLock, ensuring proper synchronization.
pub struct ConfigLock {
_guard: std::sync::MutexGuard<'static, ()>,
config: Arc<RwLock<Attrs>>,
}

impl ConfigLock {
Expand All @@ -243,7 +254,7 @@ pub mod global {
value: T,
) -> ConfigValueGuard<'a, T> {
let orig = {
let mut config = CONFIG.write().unwrap();
let mut config = self.config.write().unwrap();
let orig = config.take_value(key);
config.set(key, value);
orig
Expand All @@ -252,6 +263,7 @@ pub mod global {
ConfigValueGuard {
key,
orig,
config: self.config.clone(),
_phantom: PhantomData,
}
}
Expand All @@ -261,13 +273,14 @@ pub mod global {
pub struct ConfigValueGuard<'a, T: 'static> {
key: crate::attrs::Key<T>,
orig: Option<Box<dyn crate::attrs::SerializableValue>>,
config: Arc<RwLock<Attrs>>,
// This is here so we can hold onto a 'a lifetime.
_phantom: PhantomData<&'a ()>,
}

impl<T: 'static> Drop for ConfigValueGuard<'_, T> {
fn drop(&mut self) {
let mut config = CONFIG.write().unwrap();
let mut config = self.config.write().unwrap();
if let Some(orig) = self.orig.take() {
config.restore_value(self.key, orig);
} else {
Expand Down
Loading
Loading