Skip to content

Sweep major CMake files for use of include/lib instead of CMAKE_INSTALL_INCLUDE/LIBDIR #12792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 128 commits into from
Oct 7, 2025
Merged

Sweep major CMake files for use of include/lib instead of CMAKE_INSTALL_INCLUDE/LIBDIR #12792

merged 128 commits into from
Oct 7, 2025

Conversation

swolchok
Copy link
Contributor

Supposed to use the latter. (This is the thing that causes binaries to show up in lib64 for some weird builds, for example.)

swolchok added 30 commits March 4, 2025 17:40
@swolchok
Update
6d51bff 
[ghstack-poisoned]
@swolchok
Update
9e3e2e7 
[ghstack-poisoned]
@swolchok
forgot to amend
16f0274 
[ghstack-poisoned]
@swolchok
Update
99ec5a7 
[ghstack-poisoned]
@swolchok
Update
ff3cdb9 
[ghstack-poisoned]
@swolchok
Update
513de13 
[ghstack-poisoned]
@swolchok
Update
76db1f1 
[ghstack-poisoned]
@swolchok
Update
08bffac 
[ghstack-poisoned]
@swolchok
Update
dff96c8 
[ghstack-poisoned]
@swolchok
Update
0e2bce6 
[ghstack-poisoned]
@swolchok
Update
35d8319 
[ghstack-poisoned]
@swolchok
Update
b87d2fb 
[ghstack-poisoned]
@swolchok
Update
a31187e 
[ghstack-poisoned]
@swolchok
Update
dcbce0d 
[ghstack-poisoned]
@swolchok
Update
bc8f971 
[ghstack-poisoned]
@swolchok
Update
29d3999 
[ghstack-poisoned]
@swolchok
Update
7e4040a 
[ghstack-poisoned]
@swolchok
Update
2dacf6f 
[ghstack-poisoned]
@swolchok
Update
497ea70 
[ghstack-poisoned]
@swolchok
Update
fb2b775 
[ghstack-poisoned]
@swolchok
Update
02f19a6 
[ghstack-poisoned]
@swolchok
Update
225d5a6 
[ghstack-poisoned]
@swolchok
Update
f8d2baf 
[ghstack-poisoned]
@swolchok
Update
41bf264 
[ghstack-poisoned]
@swolchok
Update
f54a8ce 
[ghstack-poisoned]
@swolchok
Update
e48e6cc 
[ghstack-poisoned]
@swolchok
Update
62658a6 
[ghstack-poisoned]
@swolchok
Update
a2f14ac 
[ghstack-poisoned]
@swolchok
stack on #12566
46e9698 
[ghstack-poisoned]
@swolchok
Update
4ac87e3 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 24, 2025
@swolchok
Sweep major CMake files for use of include/lib instead of CMAKE_INSTA…
ff6f743 
…LL_INCLUDE/LIBDIR

Supposed to use the latter. (This is the thing that causes binaries to show up in lib64 for some weird builds, for example.)


ghstack-source-id: d9e3ca9
ghstack-comment-id: 3111516638
Pull-Request: #12792
swolchok added a commit that referenced this pull request Jul 24, 2025
@swolchok
Sweep major CMake files for use of include/lib instead of CMAKE_INSTA…
2670347 
…LL_INCLUDE/LIBDIR

Supposed to use the latter. (This is the thing that causes binaries to show up in lib64 for some weird builds, for example.)


ghstack-source-id: 1d9aa86
ghstack-comment-id: 3111516638
Pull-Request: #12792
swolchok added a commit that referenced this pull request Jul 24, 2025
@swolchok
Sweep major CMake files for use of include/lib instead of CMAKE_INSTA…
5eaf32e 
…LL_INCLUDE/LIBDIR

Supposed to use the latter. (This is the thing that causes binaries to show up in lib64 for some weird builds, for example.)


ghstack-source-id: cd2627e
ghstack-comment-id: 3111516638
Pull-Request: #12792
swolchok added 2 commits July 24, 2025 17:59
@swolchok
Update
db7c3cd 
[ghstack-poisoned]
@swolchok
Update
abb4148 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 25, 2025
@swolchok
Sweep major CMake files for use of include/lib instead of CMAKE_INSTA…
6aaffa4 
…LL_INCLUDE/LIBDIR

Supposed to use the latter. (This is the thing that causes binaries to show up in lib64 for some weird builds, for example.)


ghstack-source-id: c3b72a9
ghstack-comment-id: 3111516638
Pull-Request: #12792
Base automatically changed from gh/swolchok/310/head to main July 25, 2025 21:56
@github-actions GitHub Actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 24, 2025
@swolchok swolchok mentioned this pull request Oct 4, 2025
Closed
@swolchok
rebase, fix a few more sites
942556e 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Oct 6, 2025
@swolchok
Sweep major CMake files for use of include/lib instead of CMAKE_INSTA…
cba9d35 
…LL_INCLUDE/LIBDIR

Supposed to use the latter. (This is the thing that causes binaries to show up in lib64 for some weird builds, for example.)

ghstack-source-id: 569b23b
ghstack-comment-id: 3111516638
Pull-Request: #12792
@swolchok swolchok added ciflow/trunk and removed stale PRs inactive for over 60 days labels Oct 6, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Oct 7, 2025

build-demo-ios is known broken, other two failures look fine to bypsas as we are looking for cmake problems here. merging.

@swolchok swolchok merged commit 351d82f into main Oct 7, 2025
285 of 297 checks passed
@swolchok swolchok deleted the gh/swolchok/530/head branch October 7, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@mergennachin mergennachin Awaiting requested review from mergennachin

@digantdesai digantdesai Awaiting requested review from digantdesai

@mcr229 mcr229 Awaiting requested review from mcr229

@cccclai cccclai Awaiting requested review from cccclai

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @GregoryComer @facebook-github-bot