Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 12, 2025

Set a manual seed for pytorch based on the test base name (test case not including flow / etc.). This makes test results stable between runs and between backends/flows. This is useful for comparing accuracy between backends, for example.

I validated this change by running convolution tests for xnnpack twice. I validated that the output accuracy statistics were identical.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 12, 2025
ghstack-source-id: f3c1119
ghstack-comment-id: 3177836622
Pull-Request: #13313
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 13, 2025
ghstack-source-id: f123042
ghstack-comment-id: 3177836622
Pull-Request: #13313
GregoryComer added a commit that referenced this pull request Aug 13, 2025
ghstack-source-id: f123042
ghstack-comment-id: 3177836622
Pull-Request: #13313
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/123/head to main August 13, 2025 20:51
[ghstack-poisoned]
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 13, 2025
@GregoryComer GregoryComer merged commit 7cb8295 into main Aug 13, 2025
104 of 105 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/124/head branch August 13, 2025 22:01
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Set a manual seed for pytorch based on the test base name (test case not
including flow / etc.). This makes test results stable between runs and
between backends/flows. This is useful for comparing accuracy between
backends, for example.

I validated this change by running convolution tests for xnnpack twice.
I validated that the output accuracy statistics were identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants