Alpha version of utimensat, more utime calls incoming

Author: libumem

examples/src/linux/Makefile

@@ -23,11 +23,12 @@ TARGETS =					\
  	arm64_hello_static		\
  	arm64_sleep_hello		\
 	mips32el_hello			\
- 	mips32el_hello_static	\
-	x86_hello				\
+ 	mips32el_hello_static		\
+	x86_hello			\
  	x86_hello_static		\
  	x86_hello_cpp			\
-	x86_hello_cpp_static	\
+	x86_hello_cpp_static		\
+	x86_linux_utime			\
 	x8664_hello				\
  	x8664_hello_static		\
  	x8664_hello_cpp			\
@@ -127,7 +128,9 @@ x8664_epoll_0: x8664_epoll_0.c
 x8664_onestraw_server: x8664_onestraw_server.c
 	$(CC) $(CPPFLAGS) $(CFLAGS) -m64 -static -o $@ $<
 x8664_linux_utime: x8664_linux_utime.c
-	$(CC) $(CPPFLAGS) $(CFLAGS) -m64 -o $@ $<
+	$(CC) $(CPPFLAGS) $(CFLAGS)  -m64 -o $@ $<
+x86_linux_utime: x8664_linux_utime.c
+	$(CC) $(CPPFLAGS) $(CFLAGS) -m32 -o x86_linux_utime $<
 
 
 libpatch_test.so: patch_test.so.h patch_test.so.c

examples/src/linux/hello_mips32.s

@@ -6,10 +6,12 @@
 from qiling import Qiling
 from qiling.arch.x86_const import *
 from qiling.const import QL_ARCH
-
+from qiling.os import struct
+from qiling.os.posix.structs import *
 from datetime import datetime
 from math import floor
 import ctypes
+import os
 
 def __get_timespec_struct(archbits: int):
     long  = getattr(ctypes, f'c_int{archbits}')
@@ -90,3 +92,68 @@ def ql_syscall_gettimeofday(ql: Qiling, tv: int, tz: int):
         ql.mem.write(tz, b'\x00' * 8)
 
     return 0
+
+'''
+        TODO
+       int futimens(int fd, const struct timespec times[_Nullable 2]);
+
+'''
+
+'''
+TODO
+       int utime(const char *filename,
+                 const struct utimbuf *_Nullable times);
+
+'''
+
+'''
+TODO: This is considered deprecated,
+but should there be a wrapper added for legacy code?
+int futimesat(int dirfd, const char *pathname,
+                                    const struct timeval times[2]);
+
+'''
+
+'''
+TODO:        int utimes(const char *filename,
+                 const struct timeval times[_Nullable 2]);
+
+'''
+
+'''
+	sys_utimensat	int dfd	const char *filename	struct timespec *utimes	int flags
+'''
+def ql_syscall_utimensat(ql:qiling.Qiling, dfd: int, filename:POINTER, utimes: POINTER, flags: int):
+    path = ''
+    if dfd == AT_FDCWD:
+        ql.emu_stop()
+    ql.log.debug("inside hook")
+    if filename == 0:
+        return EACCES
+    if utimes == 0:
+        return EACCES
+    ql.log.debug(hex(filename))
+    unpacked_filename = ql.mem.string(filename)
+    if unpacked_filename.find("/") == 0: # starts with /, assumed to be absolute path
+        dfd = None
+    timespec_struct = make_timespec_buf(ql.arch.bits, ql.arch.endian)
+    atime_nsec = mtime_nsec = atime_sec = mtime_sec = 0
+    with timespec_struct.ref(ql.mem, utimes) as atime_ref:
+        atime_nsec = atime_ref.tv_nsec
+        atime_sec = atime_ref.tv_sec
+    with timespec_struct.ref(ql.mem, utimes+ctypes.sizeof(timespec_struct)) as mtime_ref:
+        mtime_nsec = mtime_ref.tv_nsec
+        mtime_sec = mtime_ref.tv_sec
+    ql.log.debug(f"Got filename {unpacked_filename} for utime syscall ")
+    try:
+        follow_symlink = True
+        if flags == AT_SYMLINK_NOFOLLOW:
+            follow_symlink = False
+        os.utime(unpacked_filename, ns=(atime_nsec, mtime_nsec), dir_fd=dfd, follow_symlinks=follow_symlink)
+        os.utime(unpacked_filename, (atime_sec, mtime_sec), dir_fd=dfd, follow_symlinks=follow_symlink)
+    except Exception as ex:
+        return -ex.errno
+    return 0
+    
+
+

examples/src/linux/hello_riscv.s

@@ -1083,4 +1083,7 @@ class qnx_mmap_prot_flags(QlPrettyFlag):
 EPOLLWAKEUP = 1 << 29
 EPOLLONESHOT = 1 << 30
 EPOLLET = 1 << 31
-EPOLL_CLOEXEC = 0x02000000
+EPOLL_CLOEXEC = 0x02000000
+
+# fcntl
+AT_SYMLINK_NOFOLLOW = 0x100

qiling/os/linux/syscall.py

@@ -143,3 +143,27 @@ class pollfd(Struct):
         )
 
     return pollfd
+
+def make_utimbuf(archbits: int, endian: QL_ENDIAN):
+    Struct = struct.get_aligned_struct(archbits, endian)
+    class utimbuf(Struct):
+        if archbits == 32:
+            _fields_ = (
+                ('actime', ctypes.c_int32),
+                ('modtime', ctypes.c_int32)
+            )
+        else:
+            _fields_ = (
+                ('actime', ctypes.c_int64),
+                ('modtime', ctypes.c_int64)
+            )
+    return utimbuf
+
+def make_timespec_buf(archbits: int, endian: QL_ENDIAN):
+    Struct = struct.get_aligned_struct(archbits, endian)
+    class timespec(Struct):
+        _fields_ = (
+            ('tv_sec', ctypes.c_long),
+            ('tv_nsec', ctypes.c_long)
+        )
+    return timespec