Skip to content

Commit 7729932

Browse files
authored
Uc query hosts order (#586)
1 parent abe1593 commit 7729932

16 files changed

+31
-26
lines changed

src/main/java/com/qiniu/storage/Api.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.qiniu.util.StringUtils;
1111
import okhttp3.MediaType;
1212
import okhttp3.MultipartBody;
13-
import okhttp3.Request;
1413
import okhttp3.RequestBody;
1514
import okio.BufferedSink;
1615

@@ -117,10 +116,7 @@ protected com.qiniu.http.Response innerRequest(Request request) throws QiniuExce
117116
MethodType method = request.getMethod();
118117
String url = request.getUrl().toString();
119118
StringMap header = request.getHeader();
120-
RequestBody body = null;
121-
if (method.hasContent()) {
122-
body = request.getRequestBody();
123-
}
119+
RequestBody body = method.hasContent() ? request.getRequestBody() : null;
124120
okhttp3.Request.Builder requestBuilder = new okhttp3.Request.Builder()
125121
.url(url)
126122
.method(method.toString(), body);

src/main/java/com/qiniu/storage/ApiInterceptorAuth.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Api.Response intercept(Api.Request request, Api.Handler handler) throws QiniuExc
3535
return handler.handle(request);
3636
}
3737

38-
final static class Builder {
38+
static final class Builder {
3939
private Auth auth;
4040

4141
Builder setAuth(Auth auth) {

src/main/java/com/qiniu/storage/ApiQueryRegion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class ApiQueryRegion extends Api {
2020
public ApiQueryRegion(Client client) {
2121
this(client, new Api.Config.Builder()
2222
.setHostRetryMax(DEFAULT_UC_BACKUP_HOSTS.length)
23-
.setHostProvider(HostProvider.ArrayProvider(DEFAULT_UC_BACKUP_HOSTS))
23+
.setHostProvider(HostProvider.arrayProvider(DEFAULT_UC_BACKUP_HOSTS))
2424
.build());
2525
}
2626

src/main/java/com/qiniu/storage/AutoRegion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ private UCRet queryRegionInfoFromServerIfNeeded(RegionIndex index) throws QiniuE
8888
.setRetryInterval(retryInterval)
8989
.setHostFreezeDuration(hostFreezeDuration)
9090
.setHostRetryMax(ucHosts.length)
91-
.setHostProvider(HostProvider.ArrayProvider(ucHosts))
91+
.setHostProvider(HostProvider.arrayProvider(ucHosts))
9292
.build());
9393
Response r = api.requestWithInterceptor(new Api.Request(address));
9494
ret = r.jsonToObject(UCRet.class);

src/main/java/com/qiniu/storage/BucketManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1205,7 +1205,7 @@ private Api.Interceptor[] ucInterceptors() throws QiniuException {
12051205
Api.Interceptor hostRetryInterceptor = new ApiInterceptorRetryHosts.Builder()
12061206
.setRetryMax(config.retryMax)
12071207
.setRetryInterval(Retry.staticInterval(config.retryInterval))
1208-
.setHostProvider(HostProvider.ArrayProvider(ucHosts))
1208+
.setHostProvider(HostProvider.arrayProvider(ucHosts))
12091209
.setHostFreezeDuration(config.hostFreezeDuration)
12101210
.build();
12111211
return new Api.Interceptor[]{authInterceptor, hostRetryInterceptor};

src/main/java/com/qiniu/storage/ConfigHelper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.qiniu.util.UrlUtils;
88

99
import java.util.*;
10-
import java.util.function.Function;
1110

1211
class ConfigHelper {
1312
private Configuration config;

src/main/java/com/qiniu/storage/Configuration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ public final class Configuration implements Cloneable {
1919
*/
2020
public static String defaultRsHost = "rs.qiniu.com";
2121
public static String defaultApiHost = "api.qiniu.com";
22-
public static String defaultUcHost = "uc.qbox.me";
22+
public static String defaultUcHost = "kodo-config.qiniuapi.com";
2323

24-
static final String ucBackUpHost0 = "kodo-config.qiniuapi.com";
24+
static final String ucBackUpHost0 = "uc.qbox.me";
2525
static final String[] defaultUcHosts = new String[]{defaultUcHost, ucBackUpHost0, defaultApiHost};
2626

2727
/**

src/main/java/com/qiniu/storage/FormUploader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Response uploadFlows() throws QiniuException {
7878
.setHostRetryMax(config.retryMax)
7979
.setRetryInterval(Retry.staticInterval(config.retryInterval))
8080
.setHostFreezeDuration(config.hostFreezeDuration)
81-
.setHostProvider(HostProvider.ArrayProvider(this.configHelper.upHostsWithoutScheme().toArray(new String[0])))
81+
.setHostProvider(HostProvider.arrayProvider(this.configHelper.upHostsWithoutScheme().toArray(new String[0])))
8282
.build());
8383
Api.Request request = new Api.Request(urlPrefix);
8484
request.setMethod(MethodType.POST);

src/main/java/com/qiniu/storage/HostProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
public abstract class HostProvider {
1010

11-
public static HostProvider ArrayProvider(String... hosts) {
11+
public static HostProvider arrayProvider(String... hosts) {
1212
if (hosts == null || hosts.length == 0) {
1313
return null;
1414
}

src/main/java/com/qiniu/storage/ResumeUploadPerformer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ abstract class ResumeUploadPerformer {
3636
.setHostRetryMax(ipHosts.size())
3737
.setRetryInterval(Retry.staticInterval(config.retryInterval))
3838
.setHostFreezeDuration(config.hostFreezeDuration)
39-
.setHostProvider(HostProvider.ArrayProvider(ipHosts.toArray(new String[0])))
39+
.setHostProvider(HostProvider.arrayProvider(ipHosts.toArray(new String[0])))
4040
.build();
4141
}
4242

0 commit comments

Comments
 (0)