1. FIX codeBeat

Author: Ox2g

src/main/java/com/qiniu/rtc/QRTC.java

@@ -53,26 +53,51 @@ public static QRTCClient init(String accessKey, String secretKey, String appId)
     /**
      * 创建app
      *
-     * @param appParam
+     * @param appParam APP创建参数
      * @return
      * @throws QiniuException
      */
     public static QRTCResult<AppResult> createApp(AppParam appParam, String accessKey, String secretKey) throws QiniuException {
         Response response = null;
         try {
-            AppService appService = new AppService(Auth.create(accessKey, secretKey));
-            response = appService.createApp(appParam);
-            if (null == response || StringUtils.isNullOrEmpty(response.bodyString())) {
-                return QRTCResult.fail(-1, "result is null");
-            }
-            AppResult t = Json.decode(response.bodyString(), AppResult.class);
-            return QRTCResult.success(response.statusCode, t);
+            response = fetchCreateApp(appParam, accessKey, secretKey);
+            return formatCreateAppResult(response);
         } finally {
             // 释放资源
             if (response != null) response.close();
         }
     }
 
+    /**
+     * 结果格式化
+     *
+     * @param response
+     * @return
+     * @throws QiniuException
+     */
+    private static QRTCResult<AppResult> formatCreateAppResult(Response response) throws QiniuException {
+        if (null == response || StringUtils.isNullOrEmpty(response.bodyString())) {
+            return QRTCResult.fail(-1, "result is null");
+        }
+        AppResult t = Json.decode(response.bodyString(), AppResult.class);
+        return QRTCResult.success(response.statusCode, t);
+    }
+
+    /**
+     * 创建请求处理
+     *
+     * @param appParam
+     * @param accessKey
+     * @param secretKey
+     * @return
+     * @throws QiniuException
+     */
+    private static Response fetchCreateApp(AppParam appParam, String accessKey, String secretKey) throws QiniuException {
+        AppService appService = new AppService(Auth.create(accessKey, secretKey));
+        return appService.createApp(appParam);
+    }
+
+
     /**
      * 根据appId 获取当前的client
      *

src/main/java/com/qiniu/rtc/RtcAppManager.java

@@ -121,4 +121,4 @@ public Response updateApp(String appId, String hub, String title, int maxUsers,
         return client.post(url, body, headers, Client.JsonMime);
     }
 
-}
+}

src/main/java/com/qiniu/rtc/RtcRoomManager.java

@@ -99,4 +99,4 @@ public String getRoomToken(String appId, String roomName, String userId,
         return auth.signRoomToken(json);
     }
 
-}
+}

src/main/java/com/qiniu/rtc/model/AppResult.java

@@ -11,7 +11,7 @@ public class AppResult {
     private int maxUsers;
     private boolean noAutoKickUser;
     private String createdAt;
-    private String UpdatedAt;
+    private String updatedAt;
     private String error;
     private String status;
 

src/main/java/com/qiniu/rtc/model/ForwardResult.java

@@ -4,6 +4,12 @@
 
 @Data
 public class ForwardResult {
+    /**
+     * 单路转推状态
+     */
     private String status;
-    private String id;//forward id
+    /**
+     * 单路转推ID
+     */
+    private String id;
 }

src/main/java/com/qiniu/rtc/model/MergeTrackParam.java

@@ -21,4 +21,4 @@ public static class MergeTrack {
         private String stretchMode;
         private boolean supportSei = false;
     }
-}
+}

src/main/java/com/qiniu/rtc/service/CallbackService.java

@@ -30,8 +30,9 @@ public CallbackService(Auth auth) {
      * @throws QiniuException
      */
     public Response setHttpCallback(String appId, CallbackParam param) throws QiniuException {
-        if (null == param || StringUtils.isNullOrEmpty(param.getEventCbUrl()) ||
-                StringUtils.isNullOrEmpty(param.getEventCbSecret())) {
+        if (null == param
+                || StringUtils.isNullOrEmpty(param.getEventCbUrl())
+                || StringUtils.isNullOrEmpty(param.getEventCbSecret())) {
             throw new IllegalArgumentException("CallbackParam cannot be null...");
         }
         param.setEventCbVersion("1");

src/main/java/com/qiniu/rtc/service/MergeService.java

@@ -69,7 +69,7 @@ public Response updateMergeWatermarks(WatermarksParam watermarksParam, UrlParam
      * @throws QiniuException
      */
     public Response stopMergeJob(String appId, String roomName, String jobId) throws QiniuException {
-        String urlPattern = "/v3/apps/<appID>/rooms/<roomName>/merge_job/<jobID>";
+        String urlPattern = "/v3/apps/%s/rooms/%s/merge_job/%s";
         return deleteCall(null, urlPattern, appId, roomName, jobId);
     }