fix possible data race issue in test cases

Author: bachue

src/test/java/com/qiniu/storage/FixBlockUploaderWithRecorderTest.java

@@ -19,6 +19,7 @@
 import java.nio.charset.Charset;
 import java.util.Date;
 import java.util.concurrent.*;
+import java.util.concurrent.atomic.AtomicBoolean;
 
 public class FixBlockUploaderWithRecorderTest {
     int blockSize = 1024 * 1024 * 8;
@@ -102,7 +103,7 @@ public void breakThenUpload(final ExecutorService pool1, final ExecutorService p
         StringMap p = new StringMap().put("returnBody", returnBody);
 
         final String token = TestConfig.testAuth.uploadToken(bucket, expectKey, 3600, p);
-        final int[] t1Finished = { 0 };
+        final AtomicBoolean t1Finished = new AtomicBoolean(false);
 
         Thread t1 = new Thread() {
             @Override
@@ -154,14 +155,14 @@ public void run() {
         int it1Finished = 0;
         for (; it1Finished < 1500; it1Finished++) {
             doSleep(100);
-            if (t1Finished[0] == 1) {
+            if (t1Finished.get()) {
                 break;
             }
         }
-        System.out.println("t1Finished[0] == 1    " + (t1Finished[0] == 1) + "     " + it1Finished);
+        System.out.println("t1Finished.get() == true    " + t1Finished.get() + "     " + it1Finished);
         doSleep(1500);
         final FixBlockUploader.FileBlockData fbd2 = new FixBlockUploader.FileBlockData(blockSize, f);
-        final int[] t2Finished = { 0 };
+        final AtomicBoolean t2Finished = new AtomicBoolean(false);
         Thread t2 = new Thread() {
             @Override
             public void run() {
@@ -197,11 +198,11 @@ public void run() {
         int it2Finished = 0;
         for (; it2Finished < 1500; it2Finished++) {
             doSleep(100);
-            if (t2Finished[0] == 1) {
+            if (t2Finished.get()) {
                 break;
             }
         }
-        System.out.println("t2Finished[0] == 1    " + (t2Finished[0] == 1) + "     " + it2Finished);
+        System.out.println("t2Finished.get() == true    " + t2Finished.get() + "     " + it2Finished);
         doSleep(1500);
         System.out.println("------ start 3, " + new Date());
         try {
@@ -232,7 +233,7 @@ public void run() {
     }
 
     private void upload(int idx, FixBlockUploader.FileBlockData fbd, String token, String expectKey,
-            final ExecutorService pool, int maxRunningBlock, final int[] tFinished, String etag) {
+            final ExecutorService pool, int maxRunningBlock, final AtomicBoolean tFinished, String etag) {
         try {
             System.out.println("------ start " + idx + ", " + new Date());
             Response r = up.upload(fbd, new FixBlockUploader.StaticToken(token), expectKey, null, pool,
@@ -242,10 +243,10 @@ private void upload(int idx, FixBlockUploader.FileBlockData fbd, String token, S
             assertEquals(expectKey, ret.key);
             assertEquals(String.valueOf(fbd.size()), ret.fsize);
             assertEquals(etag, ret.hash);
-            tFinished[0] = 1;
+            tFinished.set(true);
         } catch (Exception e) {
             System.out.println("======= end " + idx + ":     ");
-            tFinished[0] = 1;
+            tFinished.set(true);
             e.printStackTrace();
         }
     }

src/test/java/test/com/qiniu/storage/RecordUploadTest.java

@@ -21,6 +21,8 @@
 import java.lang.reflect.Method;
 import java.util.Date;
 import java.util.Random;
+import java.util.concurrent.atomic.AtomicBoolean;
+
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 
@@ -89,15 +91,15 @@ public void run() {
                             System.out.println("UP:  " + i + ", exception run");
                             e.printStackTrace();
                         }
-                        complete.isComplete = true;
+                        complete.isComplete.set(true);
                     }
                 }.start();
 
-                final boolean[] ch = new boolean[] { true };
+                final AtomicBoolean ch = new AtomicBoolean(true);
                 // 显示断点记录文件
                 Thread showRecord = new Thread() {
                     public void run() {
-                        for (; ch[0];) {
+                        while (ch.get()) {
                             doSleep(1000);
                             showRecord("normal: " + size + " :", recorder, recordKey);
                         }
@@ -122,7 +124,7 @@ public void run() {
                 }
 
                 System.out.println("response is " + response);
-                while (!complete.isComplete) {
+                while (!complete.isComplete.get()) {
                     doSleep(200);
                 }
 
@@ -138,7 +140,7 @@ public void run() {
 
                 showRecord("done: " + size + " :", recorder, recordKey);
 
-                ch[0] = false;
+                ch.set(false);
 
                 String etag = Etag.file(f);
                 System.out.println("etag: " + etag);
@@ -363,6 +365,6 @@ public Response up(Region region) throws Exception {
     }
 
     static class Complete {
-        boolean isComplete = false;
+        AtomicBoolean isComplete = new AtomicBoolean(false);
     }
 }