ci: don't run test jobs after a failed or skipped build

A job with `needs:` and no `if:` gets an implicit `success()`, but an
explicit `if:` replaces it rather than adding to it. Four jobs which
carry a condition of their own therefore run whatever their dependency
did: `test` in build.yml, `test-debian` in build-debian.yml and
`debos-linux-deb` and `test-linux-deb` in linux.yml. Once the build
they need fails, the image URL they pass on is empty and LAVA jobs are
submitted against nothing, which is the exact inverse of the missing
results this branch otherwise fixes.

Check the result of the dependency in the condition. Comparing it
against 'success' rather than calling `success()` also covers the case
where the dependency was skipped, e.g. when build-linux-deb is guarded
out because the workflow runs from a fork.

Signed-off-by: Christopher Obbard <chris.obbard@oss.qualcomm.com>

Author: obbardc

.github/workflows/build-debian.yml

@@ -47,11 +47,16 @@ jobs:
   test-debian:
     # don't run cron from forks of the main repository or from other branches;
     # manual runs are allowed from any branch of the main repository so
-    # that changes to the workflows can be tested before they are merged
+    # that changes to the workflows can be tested before they are merged.
+    # this explicit if: replaces the implicit success(), so the state of the
+    # build job has to be checked too, otherwise LAVA jobs would be submitted
+    # with an empty image url once it fails; checking the result rather than
+    # calling success() also covers the case where the build was skipped
     if: >-
       github.repository == 'qualcomm-linux/qcom-deb-images' &&
       (github.event_name == 'workflow_dispatch' ||
-      github.ref == 'refs/heads/main')
+      github.ref == 'refs/heads/main') &&
+      needs.build-debian.result == 'success'
     strategy:
       fail-fast: false
       matrix:

.github/workflows/build.yml

@@ -57,11 +57,16 @@ jobs:
   test:
     # don't run from forks of the main repository or from other branches;
     # manual runs are allowed from any branch of the main repository so
-    # that changes to the workflows can be tested before they are merged
+    # that changes to the workflows can be tested before they are merged.
+    # this explicit if: replaces the implicit success(), so the state of the
+    # build job has to be checked too, otherwise LAVA jobs would be submitted
+    # with an empty image url once it fails; checking the result rather than
+    # calling success() also covers the case where the build was skipped
     if: >-
       github.repository == 'qualcomm-linux/qcom-deb-images' &&
       (github.event_name == 'workflow_dispatch' ||
-      github.ref == 'refs/heads/main')
+      github.ref == 'refs/heads/main') &&
+      needs.build.result == 'success'
     strategy:
       fail-fast: false
       matrix:

.github/workflows/linux.yml

@@ -183,7 +183,14 @@ jobs:
           destination: ${{ github.repository_owner }}/${{ github.event.repository.name }}/${{ github.run_id }}-${{ github.run_attempt }}/
 
   debos-linux-deb:
-    if: ${{ !inputs.skip_image_build }}
+    # an explicit if: replaces the implicit success(), so the state of the
+    # dependency has to be checked here as well; without it the image would
+    # be built from a kernel build which failed or never ran. checking the
+    # result rather than calling success() also covers the skipped case,
+    # e.g. when build-linux-deb is guarded out on a fork
+    if: >-
+      ${{ !inputs.skip_image_build &&
+      needs.build-linux-deb.result == 'success' }}
     needs: build-linux-deb
     strategy:
       fail-fast: false
@@ -199,7 +206,11 @@ jobs:
       skip_qemu_tests: ${{ inputs.skip_qemu_tests || false }}
 
   test-linux-deb:
-    if: ${{ !inputs.skip_lava_tests }}
+    # as above: without checking the dependency's result, LAVA jobs would be
+    # submitted with an empty image url after a failed or skipped image build
+    if: >-
+      ${{ !inputs.skip_lava_tests &&
+      needs.debos-linux-deb.result == 'success' }}
     strategy:
       fail-fast: false
       matrix: