-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #7510: remove outdated notebook about XEB #7519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Per @eliottrosenberg's report in issue quantumlib#7510, the notebook at [quantumai.google/cirq/noise/qcvv/xeb_calibration_example](https://quantumai.google/cirq/noise/qcvv/xeb_calibration_example) is out of date and should be deleted.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mhucka!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few more references to the deleted notebook, can you please clean those?
$ git grep -n xeb_calibration_example
docs/google/best_practices.ipynb:520: "* [XEB calibration example](../noise/qcvv/xeb_calibration_example.ipynb)\n",
docs/tutorials/google/identifying_hardware_changes.ipynb:528: "* Other than for qubit picking, you should also use calibration for error compensation. The [Coherent vs incoherent noise with XEB](../../noise/qcvv/coherent_vs_incoherent_xeb.ipynb), [XEB Calibration Example](../../noise/qcvv/xeb_calibration_example.ipynb), [Parallel XEB](../../noise/qcvv/parallel_xeb.ipynb) and [Isolated XEB](../../noise/qcvv/isolated_xeb.ipynb) tutorials demonstrate how to run a classical optimizer on collected two-qubit gate characterization data, identity the true unitary matrix implemented by each gate, and add [Virtual Pauli Z gates](../../hardware/devices.ipynb) to compensate for the identified error, improving the reliability of your circuit.\n",
Otherwise LGTM. Can we get this in for the 1.6 release?
PS: The tests should hopefully pass after bee71e5.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7519 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 1095 1095
Lines 99002 99002
=======================================
+ Hits 96560 96566 +6
+ Misses 2442 2436 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This should hopefully be fixed up now. Thanks for fixing the test scripts already. |
There is still one reference to xeb_calibration_example left, please correct. |
Good catch. I am curious how you found it. Did you manually run a grep or do you have an automated way? |
I ran grep, the command from a comment above. PS: sorry about editing your comment, somehow I got into edit mode instead of quote-reply. :-/ |
Per @eliottrosenberg's report in issue #7510, the notebook at quantumai.google/cirq/noise/qcvv/xeb_calibration_example is out of date and should be deleted.