Skip to content

Fix #7510: remove outdated notebook about XEB #7519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Jul 20, 2025

Per @eliottrosenberg's report in issue #7510, the notebook at quantumai.google/cirq/noise/qcvv/xeb_calibration_example is out of date and should be deleted.

Per @eliottrosenberg's report in issue quantumlib#7510, the notebook at
[quantumai.google/cirq/noise/qcvv/xeb_calibration_example](https://quantumai.google/cirq/noise/qcvv/xeb_calibration_example)
is out of date and should be deleted.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the size: L 250< lines changed <1000 label Jul 20, 2025
@mhucka mhucka marked this pull request as ready for review July 20, 2025 23:39
@mhucka mhucka requested review from mrwojtek, vtomole and a team as code owners July 20, 2025 23:39
@mhucka mhucka requested a review from dabacon July 20, 2025 23:40
Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mhucka!

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few more references to the deleted notebook, can you please clean those?

$ git grep -n xeb_calibration_example
docs/google/best_practices.ipynb:520:    "* [XEB calibration example](../noise/qcvv/xeb_calibration_example.ipynb)\n",
docs/tutorials/google/identifying_hardware_changes.ipynb:528:    "*    Other than for qubit picking, you should also use calibration for error compensation. The [Coherent vs incoherent noise with XEB](../../noise/qcvv/coherent_vs_incoherent_xeb.ipynb), [XEB Calibration Example](../../noise/qcvv/xeb_calibration_example.ipynb), [Parallel XEB](../../noise/qcvv/parallel_xeb.ipynb) and [Isolated XEB](../../noise/qcvv/isolated_xeb.ipynb) tutorials demonstrate how to run a classical optimizer on collected two-qubit gate characterization data, identity the true unitary matrix implemented by each gate, and add [Virtual Pauli Z gates](../../hardware/devices.ipynb) to compensate for the identified error, improving the reliability of your circuit.\n",

Otherwise LGTM. Can we get this in for the 1.6 release?

PS: The tests should hopefully pass after bee71e5.

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (86b38ab) to head (085b7e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7519   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files        1095     1095           
  Lines       99002    99002           
=======================================
+ Hits        96560    96566    +6     
+ Misses       2442     2436    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas added the priority/before-1.6 Finish before the Cirq 1.6 release label Jul 22, 2025
@mhucka mhucka requested review from wcourtney and verult as code owners July 22, 2025 05:39
@mhucka
Copy link
Contributor Author

mhucka commented Jul 22, 2025

There are few more references to the deleted notebook, can you please clean those?

$ git grep -n xeb_calibration_example
docs/google/best_practices.ipynb:520:    "* [XEB calibration example](../noise/qcvv/xeb_calibration_example.ipynb)\n",
docs/tutorials/google/identifying_hardware_changes.ipynb:528:    "*    Other than for qubit picking, you should also use calibration for error compensation. The [Coherent vs incoherent noise with XEB](../../noise/qcvv/coherent_vs_incoherent_xeb.ipynb), [XEB Calibration Example](../../noise/qcvv/xeb_calibration_example.ipynb), [Parallel XEB](../../noise/qcvv/parallel_xeb.ipynb) and [Isolated XEB](../../noise/qcvv/isolated_xeb.ipynb) tutorials demonstrate how to run a classical optimizer on collected two-qubit gate characterization data, identity the true unitary matrix implemented by each gate, and add [Virtual Pauli Z gates](../../hardware/devices.ipynb) to compensate for the identified error, improving the reliability of your circuit.\n",

Otherwise LGTM. Can we get this in for the 1.6 release?

This should hopefully be fixed up now. Thanks for fixing the test scripts already.

@mhucka mhucka requested a review from pavoljuhas July 22, 2025 05:49
@pavoljuhas
Copy link
Collaborator

There is still one reference to xeb_calibration_example left, please correct.

@mhucka mhucka added this pull request to the merge queue Jul 22, 2025
@mhucka mhucka removed this pull request from the merge queue due to a manual request Jul 22, 2025
@mhucka
Copy link
Contributor Author

mhucka commented Jul 22, 2025

There is still one reference to xeb_calibration_example left, please correct.

Good catch. I am curious how you found it. Did you manually run a grep or do you have an automated way?

@pavoljuhas
Copy link
Collaborator

... Did you manually run a grep or do you have an automated way?

I ran grep, the command from a comment above.

PS: sorry about editing your comment, somehow I got into edit mode instead of quote-reply. :-/

@mhucka mhucka enabled auto-merge July 22, 2025 17:53
@mhucka mhucka added this pull request to the merge queue Jul 22, 2025
Merged via the queue into quantumlib:main with commit cd32133 Jul 22, 2025
65 of 66 checks passed
@mhucka mhucka deleted the mh-fix-7510 branch July 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/before-1.6 Finish before the Cirq 1.6 release size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants